Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-20 Thread Fabio Estevam
On Tue, Jun 12, 2018 at 5:24 PM, Nishanth Menon wrote: > As recommended by Arm in [1], ACTLR[0] (Enable invalidates of BTB) > needs to be set[2] for BTB to be invalidated on ICIALLU. This needs to > be done unconditionally for Cortex-A15 processors. Provide a config > option for platforms to

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-14 Thread Nishanth Menon
On 21:36-20180613, Florian Fainelli wrote: [...] > >>> c) This workaround applies to only the boot processor. It is important > >>> to apply workaround as necessary (context-save-restore) around low > >>> power context loss OR additional processors as necessary in either > >>> firmware

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-13 Thread Marek Vasut
On 06/13/2018 11:32 PM, Nishanth Menon wrote: > On 15:46-20180613, Tom Rini wrote: >> On Wed, Jun 13, 2018 at 08:32:15AM -0500, Nishanth Menon wrote: >>> On 23:05-20180612, Marek Vasut wrote: On 06/12/2018 10:24 PM, Nishanth Menon wrote: >>> [..] > +#ifdef

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-13 Thread Florian Fainelli
On 06/13/2018 06:37 AM, Nishanth Menon wrote: > On 00:30-20180613, Florian Fainelli wrote: >> On June 12, 2018 1:24:09 PM PDT, Nishanth Menon wrote: >>> As recommended by Arm in [1], ACTLR[0] (Enable invalidates of BTB) >>> needs to be set[2] for BTB to be invalidated on ICIALLU. This needs to

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-13 Thread Nishanth Menon
On 15:46-20180613, Tom Rini wrote: > On Wed, Jun 13, 2018 at 08:32:15AM -0500, Nishanth Menon wrote: > > On 23:05-20180612, Marek Vasut wrote: > > > On 06/12/2018 10:24 PM, Nishanth Menon wrote: > > [..] > > > > +#ifdef CONFIG_ARM_CORTEX_A15_CVE_2017_5715 > > > > + mrc p15, 0, r0, c1,

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-13 Thread Tom Rini
On Wed, Jun 13, 2018 at 08:32:15AM -0500, Nishanth Menon wrote: > On 23:05-20180612, Marek Vasut wrote: > > On 06/12/2018 10:24 PM, Nishanth Menon wrote: > [..] > > > +#ifdef CONFIG_ARM_CORTEX_A15_CVE_2017_5715 > > > + mrc p15, 0, r0, c1, c0, 1 @ read auxilary control register > > > + orr

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-13 Thread Nishanth Menon
On 00:30-20180613, Florian Fainelli wrote: > On June 12, 2018 1:24:09 PM PDT, Nishanth Menon wrote: > >As recommended by Arm in [1], ACTLR[0] (Enable invalidates of BTB) > >needs to be set[2] for BTB to be invalidated on ICIALLU. This needs to > >be done unconditionally for Cortex-A15 processors.

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-13 Thread Nishanth Menon
On 23:05-20180612, Marek Vasut wrote: > On 06/12/2018 10:24 PM, Nishanth Menon wrote: [..] > > +#ifdef CONFIG_ARM_CORTEX_A15_CVE_2017_5715 > > + mrc p15, 0, r0, c1, c0, 1 @ read auxilary control register > > + orr r0, r0, #1 << 0 @ Enable invalidates of BTB > > Can we use

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-12 Thread Florian Fainelli
On June 12, 2018 1:24:09 PM PDT, Nishanth Menon wrote: >As recommended by Arm in [1], ACTLR[0] (Enable invalidates of BTB) >needs to be set[2] for BTB to be invalidated on ICIALLU. This needs to >be done unconditionally for Cortex-A15 processors. Provide a config >option for platforms to enable

Re: [U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-12 Thread Marek Vasut
On 06/12/2018 10:24 PM, Nishanth Menon wrote: > As recommended by Arm in [1], ACTLR[0] (Enable invalidates of BTB) > needs to be set[2] for BTB to be invalidated on ICIALLU. This needs to > be done unconditionally for Cortex-A15 processors. Provide a config > option for platforms to enable this

[U-Boot] [PATCH 2/4] ARM: Introduce ability to enable invalidate of BTB with ICIALLU on Cortex-A15 for CVE-2017-5715

2018-06-12 Thread Nishanth Menon
As recommended by Arm in [1], ACTLR[0] (Enable invalidates of BTB) needs to be set[2] for BTB to be invalidated on ICIALLU. This needs to be done unconditionally for Cortex-A15 processors. Provide a config option for platforms to enable this option based on impact analysis for products. NOTE: