Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-11 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > - This buffering of data in this patch is intended to solve a specific > > problem that could be avoided by more clever test scripts. Instead > > of just dumping an endless stream of characters to the serial > > console independent of what U-Boot i

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-11 Thread Simon Glass
Hi Wolfgang, On 12 June 2014 01:03, Wolfgang Denk wrote: > Dear Simon, > > In message > you > wrote: >> >> > Hm... ignoring it would mean there is no way to interrupt long running >> > commands. I'm not sure if this is actually an improvement. >> > Eventually we should try to define the wante

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-11 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > Hm... ignoring it would mean there is no way to interrupt long running > > commands. I'm not sure if this is actually an improvement. > > Eventually we should try to define the wanted behaviour first. > > My initial feelingis that ^C should terminate a

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-11 Thread Simon Glass
Hi Wolfgang, On 10 June 2014 01:08, Wolfgang Denk wrote: > Dear Simon, > > In message > you > wrote: >> >> > 1) Looking at sandbox only, we should provide an implementation of >> >ctrlc() that does not consume characters from stdin - I thinkwe >> >should rather be able to react on sign

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-09 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > 1) Looking at sandbox only, we should provide an implementation of > >ctrlc() that does not consume characters from stdin - I thinkwe > >should rather be able to react on signals? > > Currently there is no signal handling, but we set up the termi

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-07 Thread Simon Glass
Hi Wolfgang, On 6 June 2014 16:10, Wolfgang Denk wrote: > Dear Simon, > > In message > you > wrote: >> >> > If this happens, I consider it a bug that should be fixed, and not >> > papered over. >> >> If you look at the code for the 'md' command it calls ctrlc() every >> now and then. Each call

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-06 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > If this happens, I consider it a bug that should be fixed, and not > > papered over. > > If you look at the code for the 'md' command it calls ctrlc() every > now and then. Each call results in a getc() which reads a character > from the console. So we l

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-06 Thread Simon Glass
Hi Wolfgang, On 5 June 2014 15:43, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1401992872-31985-3-git-send-email-...@chromium.org> you wrote: >> Sometimes it is useful to ignore Ctrl-C, because checking for it causes the >> CLI to drop characters. In particular for tests involving sa

Re: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-05 Thread Wolfgang Denk
Dear Simon Glass, In message <1401992872-31985-3-git-send-email-...@chromium.org> you wrote: > Sometimes it is useful to ignore Ctrl-C, because checking for it causes the > CLI to drop characters. In particular for tests involving sandbox, where > input commands are piped in, some commands will ca

[U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C

2014-06-05 Thread Simon Glass
Sometimes it is useful to ignore Ctrl-C, because checking for it causes the CLI to drop characters. In particular for tests involving sandbox, where input commands are piped in, some commands will call ctrlc() which will drop characters from the test script. Add a CONFIG_SYS_CTRLC_IGNORE option wh