Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-23 Thread Aneesh V
On Monday 20 February 2012 09:38 PM, Aneesh V wrote: On Saturday 18 February 2012 10:18 PM, Albert ARIBAUD wrote: Hi Aneesh, [...] I will get back with more details on the Linaro GCC 2012.01 later. I meant the Linaro GCC 2012.01 tool-chain problem This is a different problem. Some of

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-21 Thread Tom Rini
On Mon, Feb 20, 2012 at 11:19:14PM -0500, Mike Frysinger wrote: On Monday 20 February 2012 16:53:40 Simon Glass wrote: On Mon, Feb 20, 2012 at 12:07 PM, Tom Rini wrote: On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote: On Saturday 18 February 2012 17:03:59 Simon Glass wrote:

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-21 Thread Mike Frysinger
On Tuesday 21 February 2012 09:33:31 Tom Rini wrote: On Mon, Feb 20, 2012 at 11:19:14PM -0500, Mike Frysinger wrote: On Monday 20 February 2012 16:53:40 Simon Glass wrote: On Mon, Feb 20, 2012 at 12:07 PM, Tom Rini wrote: On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote:

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-21 Thread Aneesh V
On Tuesday 21 February 2012 09:12 PM, Mike Frysinger wrote: On Tuesday 21 February 2012 09:33:31 Tom Rini wrote: On Mon, Feb 20, 2012 at 11:19:14PM -0500, Mike Frysinger wrote: On Monday 20 February 2012 16:53:40 Simon Glass wrote: On Mon, Feb 20, 2012 at 12:07 PM, Tom Rini wrote: On Sun,

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-21 Thread Mike Frysinger
On Tuesday 21 February 2012 13:03:55 Aneesh V wrote: I was planning to do that in the next revision of this series. BTW, I guess the following in the arm linkage.h of kernel is useful too. Any thoughts? #define __ALIGN .align 0 #define __ALIGN_STR .align 0 arm allows unaligned instruction

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-21 Thread Aneesh V
On Wednesday 22 February 2012 12:58 AM, Mike Frysinger wrote: On Tuesday 21 February 2012 13:03:55 Aneesh V wrote: I was planning to do that in the next revision of this series. BTW, I guess the following in the arm linkage.h of kernel is useful too. Any thoughts? #define __ALIGN .align 0

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-20 Thread Aneesh V
On Saturday 18 February 2012 10:18 PM, Albert ARIBAUD wrote: Hi Aneesh, [...] I will get back with more details on the Linaro GCC 2012.01 later. I meant the Linaro GCC 2012.01 tool-chain problem This is a different problem. Some of the .rodata symbols are given an odd address although

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-20 Thread Tom Rini
On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote: On Saturday 18 February 2012 17:03:59 Simon Glass wrote: On Wed, Feb 15, 2012 at 5:57 AM, Aneesh V wrote: -.globl reset_cpu +.type reset_cpu, %function +.globalreset_cpu Should we introduce a macro to deal

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-20 Thread Simon Glass
Hi Tom, Aneesh, On Mon, Feb 20, 2012 at 12:07 PM, Tom Rini tr...@ti.com wrote: On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote: On Saturday 18 February 2012 17:03:59 Simon Glass wrote: On Wed, Feb 15, 2012 at 5:57 AM, Aneesh V wrote: -.globl reset_cpu +.type  reset_cpu,

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-20 Thread Mike Frysinger
On Monday 20 February 2012 15:07:46 Tom Rini wrote: On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote: On Saturday 18 February 2012 17:03:59 Simon Glass wrote: On Wed, Feb 15, 2012 at 5:57 AM, Aneesh V wrote: -.globl reset_cpu +.type reset_cpu, %function +.global

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-20 Thread Mike Frysinger
On Monday 20 February 2012 16:53:40 Simon Glass wrote: On Mon, Feb 20, 2012 at 12:07 PM, Tom Rini wrote: On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote: On Saturday 18 February 2012 17:03:59 Simon Glass wrote: On Wed, Feb 15, 2012 at 5:57 AM, Aneesh V wrote: -.globl

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-20 Thread Simon Glass
Hi Mike, On Mon, Feb 20, 2012 at 8:19 PM, Mike Frysinger vap...@gentoo.org wrote: On Monday 20 February 2012 16:53:40 Simon Glass wrote: On Mon, Feb 20, 2012 at 12:07 PM, Tom Rini wrote: On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote: On Saturday 18 February 2012 17:03:59

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-18 Thread Albert ARIBAUD
Hi Aneesh, Le 17/02/2012 12:09, Aneesh V a écrit : Hi Albert, On Wednesday 15 February 2012 07:27 PM, Aneesh V wrote: This is done using the following directive preceding each function definition: .typefunc-name, %function This marks the symbol as a function in the object header which in

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-18 Thread Aneesh V
On Friday 17 February 2012 10:43 PM, Mike Frysinger wrote: On Wednesday 15 February 2012 08:57:31 Aneesh V wrote: This is done using the following directive preceding each function definition: .typefunc-name, %function This marks the symbol as a function in the object header which in turn

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-18 Thread Albert ARIBAUD
Hi Aneesh, Le 18/02/2012 12:12, Aneesh V a écrit : On Friday 17 February 2012 10:43 PM, Mike Frysinger wrote: On Wednesday 15 February 2012 08:57:31 Aneesh V wrote: This is done using the following directive preceding each function definition: .typefunc-name, %function This marks the symbol

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-18 Thread Aneesh V
Hi Albert, On Saturday 18 February 2012 03:43 PM, Albert ARIBAUD wrote: Hi Aneesh, Le 17/02/2012 12:09, Aneesh V a écrit : Hi Albert, On Wednesday 15 February 2012 07:27 PM, Aneesh V wrote: This is done using the following directive preceding each function definition: .typefunc-name,

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-18 Thread Albert ARIBAUD
Hi Aneesh, Le 18/02/2012 14:24, Aneesh V a écrit : Hi Albert, On Saturday 18 February 2012 03:43 PM, Albert ARIBAUD wrote: Hi Aneesh, Le 17/02/2012 12:09, Aneesh V a écrit : Hi Albert, On Wednesday 15 February 2012 07:27 PM, Aneesh V wrote: This is done using the following directive

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-18 Thread Aneesh V
On Saturday 18 February 2012 06:54 PM, Aneesh V wrote: Hi Albert, On Saturday 18 February 2012 03:43 PM, Albert ARIBAUD wrote: Hi Aneesh, Le 17/02/2012 12:09, Aneesh V a écrit : Hi Albert, On Wednesday 15 February 2012 07:27 PM, Aneesh V wrote: This is done using the following directive

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-18 Thread Albert ARIBAUD
Hi Aneesh, Le 18/02/2012 17:34, Aneesh V a écrit : On Saturday 18 February 2012 06:54 PM, Aneesh V wrote: Hi Albert, On Saturday 18 February 2012 03:43 PM, Albert ARIBAUD wrote: Hi Aneesh, Le 17/02/2012 12:09, Aneesh V a écrit : Hi Albert, On Wednesday 15 February 2012 07:27 PM, Aneesh V

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-18 Thread Simon Glass
Hi Anesh, On Wed, Feb 15, 2012 at 5:57 AM, Aneesh V ane...@ti.com wrote: This is done using the following directive preceding each function definition: .type func-name, %function This marks the symbol as a function in the object header which in turn helps the linker in some cases. In

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-18 Thread Mike Frysinger
On Saturday 18 February 2012 17:03:59 Simon Glass wrote: On Wed, Feb 15, 2012 at 5:57 AM, Aneesh V wrote: -.globl reset_cpu +.type reset_cpu, %function +.globalreset_cpu Should we introduce a macro to deal with this rather than writing it out each time? EXPORT()? we have it

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-17 Thread Aneesh V
Hi Albert, On Wednesday 15 February 2012 07:27 PM, Aneesh V wrote: This is done using the following directive preceding each function definition: .typefunc-name, %function This marks the symbol as a function in the object header which in turn helps the linker in some cases. In particular

Re: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-17 Thread Mike Frysinger
On Wednesday 15 February 2012 08:57:31 Aneesh V wrote: This is done using the following directive preceding each function definition: .type func-name, %function This marks the symbol as a function in the object header which in turn helps the linker in some cases. In particular this was

[U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

2012-02-15 Thread Aneesh V
This is done using the following directive preceding each function definition: .type func-name, %function This marks the symbol as a function in the object header which in turn helps the linker in some cases. In particular this was found needed for resolving ARM/Thumb calls correctly in a build