[U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-13 Thread Sergei Ianovich
I always used tftp in my test, so the first dm9000 on LP-8x4x was always properly initialized. However, if the boot doesn't include network related commands, linux will not find a valid MAC and will complain. No longer. Signed-off-by: Sergei Ianovich --- board/icpdas/lp8x4x/lp8x4x.c | 8 +++

Re: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-14 Thread Marek Vasut
On Saturday, December 14, 2013 at 06:41:58 AM, Sergei Ianovich wrote: > I always used tftp in my test, so the first dm9000 on LP-8x4x was > always properly initialized. However, if the boot doesn't include > network related commands, linux will not find a valid MAC and will > complain. > > No long

Re: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-14 Thread Sergei Ianovich
On Sat, 2013-12-14 at 13:30 +0100, Marek Vasut wrote: > On Saturday, December 14, 2013 at 06:41:58 AM, Sergei Ianovich wrote: > > I always used tftp in my test, so the first dm9000 on LP-8x4x was > > always properly initialized. However, if the boot doesn't include > > network related commands, lin

Re: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-14 Thread Marek Vasut
On Saturday, December 14, 2013 at 04:39:00 PM, Sergei Ianovich wrote: > On Sat, 2013-12-14 at 13:30 +0100, Marek Vasut wrote: > > On Saturday, December 14, 2013 at 06:41:58 AM, Sergei Ianovich wrote: > > > I always used tftp in my test, so the first dm9000 on LP-8x4x was > > > always properly initi

Re: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-14 Thread Sergei Ianovich
On Sat, 2013-12-14 at 18:12 +0100, Marek Vasut wrote: > On Saturday, December 14, 2013 at 04:39:00 PM, Sergei Ianovich wrote: > > I strongly believe the current way is easier. > > I disagree :) > > IF you set 'ethaddr' variable in U-Boot THEN > U-Boot will patch this 'ethaddr' value into your D

Re: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-14 Thread Marek Vasut
On Saturday, December 14, 2013 at 09:53:48 PM, Sergei Ianovich wrote: > On Sat, 2013-12-14 at 18:12 +0100, Marek Vasut wrote: > > On Saturday, December 14, 2013 at 04:39:00 PM, Sergei Ianovich wrote: > > > I strongly believe the current way is easier. > > > > I disagree :) > > > > IF you set 'eth

Re: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-14 Thread Sergei Ianovich
On Sat, 2013-12-14 at 21:57 +0100, Marek Vasut wrote: > > I don't think we need to support non-DT kernel. So we drop the > > patch. > > OK, that's nice :) It may even make sense to remove the code that initializes eth1, right? ___ U-Boot mailing list

Re: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-14 Thread Marek Vasut
On Sunday, December 15, 2013 at 12:53:18 AM, Sergei Ianovich wrote: > On Sat, 2013-12-14 at 21:57 +0100, Marek Vasut wrote: > > > I don't think we need to support non-DT kernel. So we drop the > > > patch. > > > > OK, that's nice :) > > It may even make sense to remove the code that initializes e

Re: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-15 Thread Sergei Ianovich
On Sun, 2013-12-15 at 06:17 +0100, Marek Vasut wrote: > On Sunday, December 15, 2013 at 12:53:18 AM, Sergei Ianovich wrote: > > It may even make sense to remove the code that initializes eth1, right? > > Which code? I mean: lp8x4x_eth1_mac_init() in board/icpdas/lp8x4x/lp8x4x.c and its invocati

Re: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-15 Thread Marek Vasut
On Sunday, December 15, 2013 at 10:44:06 AM, Sergei Ianovich wrote: > On Sun, 2013-12-15 at 06:17 +0100, Marek Vasut wrote: > > On Sunday, December 15, 2013 at 12:53:18 AM, Sergei Ianovich wrote: > > > It may even make sense to remove the code that initializes eth1, right? > > > > Which code? > >

Re: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x

2013-12-15 Thread Sergei Ianovich
On Sun, 2013-12-15 at 16:05 +0100, Marek Vasut wrote: > Heh, yes. The DT will solve it through the ethernet1 alias, just set the > eth1addr and test it to make sure please. It works. I've updated the dts in kernel for next version of patch series. I will update this patch for v2. __