[U-Boot] [PATCH 2/4] mx6: add structs for mmdc and ddr iomux registers

2013-11-08 Thread Edward Lin
Signed-off-by: Edward Lin --- arch/arm/include/asm/arch-mx6/mx6_ddr_regs.h | 167 +++ 1 file changed, 167 insertions(+) create mode 100644 arch/arm/include/asm/arch-mx6/mx6_ddr_regs.h diff --git a/arch/arm/include/asm/arch-mx6/mx6_ddr_regs.h b/arch/arm/include/asm/arch-m

Re: [U-Boot] [PATCH 2/4] mx6: add structs for mmdc and ddr iomux registers

2013-11-12 Thread Edward Lin
On Fri, 2013-11-08 at 16:42 -0700, Eric Nelson wrote: > Hi Edward, > > On 11/08/2013 02:35 AM, Edward Lin wrote: > > Signed-off-by: Edward Lin > > --- > > arch/arm/include/asm/arch-mx6/mx6_ddr_regs.h | 167 > > +++ > > 1 file changed, 167 insertions(+) > > create mode

Re: [U-Boot] [PATCH 2/4] mx6: add structs for mmdc and ddr iomux registers

2013-11-12 Thread Stefano Babic
Hi Edward, On 08/11/2013 10:35, Edward Lin wrote: > Signed-off-by: Edward Lin > --- > arch/arm/include/asm/arch-mx6/mx6_ddr_regs.h | 167 > +++ > 1 file changed, 167 insertions(+) > create mode 100644 arch/arm/include/asm/arch-mx6/mx6_ddr_regs.h > > diff --git a/arch/ar

Re: [U-Boot] [PATCH 2/4] mx6: add structs for mmdc and ddr iomux registers

2013-11-12 Thread Tapani
Stefano, I'll reply to this, since including the __attribute__ was my suggestion. > > + u32 res10[25]; > > + u32 mpmur0; > > +}__attribute__((packed, aligned(4))); > > + > > I am missing why the packed is needed. > This was discussed before, and I tried to explain it already the

Re: [U-Boot] [PATCH 2/4] mx6: add structs for mmdc and ddr iomux registers

2013-11-13 Thread Stefano Babic
Hi Tapani, On 13/11/2013 06:50, Tapani wrote: > > Stefano, > > I'll reply to this, since including the __attribute__ was my suggestion. > >>> + u32 res10[25]; >>> + u32 mpmur0; >>> +}__attribute__((packed, aligned(4))); >>> + >> >> I am missing why the packed is needed. >> > > Th

Re: [U-Boot] [PATCH 2/4] mx6: add structs for mmdc and ddr iomux registers

2013-11-08 Thread Eric Nelson
Hi Edward, On 11/08/2013 02:35 AM, Edward Lin wrote: Signed-off-by: Edward Lin --- arch/arm/include/asm/arch-mx6/mx6_ddr_regs.h | 167 +++ 1 file changed, 167 insertions(+) create mode 100644 arch/arm/include/asm/arch-mx6/mx6_ddr_regs.h diff --git a/arch/arm/includ