Re: [U-Boot] [PATCH 2/5] atmel_lcdfb: Straighten out funky vl_sync logic

Haavard Skinnemoen wrote: If the board _didn't_ request INVLINE_INVERTED, we set INVLINE_INVERTED, otherwise we don't. WTF? Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] Applied to u-boot-video/master repo. Thanks. Best regards, Anatolij -- DENX Software Engineering GmbH, MD:

Re: [U-Boot] [PATCH 2/5] atmel_lcdfb: Straighten out funky vl_sync logic

Hi Haavard, If the board _didn't_ request INVLINE_INVERTED, we set INVLINE_INVERTED, otherwise we don't. WTF? Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/video/atmel_lcdfb.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git

Re: [U-Boot] [PATCH 2/5] atmel_lcdfb: Straighten out funky vl_sync logic

Detlev Zundel [EMAIL PROTECTED] wrote: What about value |= panel_info.vl_sync (ATMEL_LCDC_INVLINE_INVERTED | ATMEL_LCDC_INVFRAME_INVERTED); [break lines where convenient] Apart from this being the formal equivalent to the original code, this would make it more clear what can go

[U-Boot] [PATCH 2/5] atmel_lcdfb: Straighten out funky vl_sync logic

If the board _didn't_ request INVLINE_INVERTED, we set INVLINE_INVERTED, otherwise we don't. WTF? Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/video/atmel_lcdfb.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/video/atmel_lcdfb.c