Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-05-06 Thread Fabio Estevam
Hi Dirk, On Sun, Apr 29, 2012 at 3:15 PM, Fabio Estevam wrote: > I sent v2 which should fix the problem you reported in v1. When you have a chance, could you please try this version and let us know if it fixes the issues you reported previously? Thanks, Fabio Estevam _

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Fabio Estevam
Dirk, On Sun, Apr 29, 2012 at 1:26 PM, Fabio Estevam wrote: > This should be fixed, but it seems it does not explain the problem you > are seeing. We need to check whether get_ahb_clk() is using the weak > definition of get_periph_clk() instead the one from clock.c. Yes, I confirmed that that g

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Stefano Babic
On 29/04/2012 18:43, Dirk Behme wrote: > Hi Stefano, > > On 29.04.2012 16:54, Fabio Estevam wrote: >> Hi Dirk, >> >> On Thu, Apr 26, 2012 at 3:04 AM, Dirk Behme >> wrote: >> >>> We had this patch on a v2012.04.1 based test branch and it showed some >>> strange issues with SD cards on i.MX6. >>> >

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Dirk Behme
Hi Stefano, On 29.04.2012 16:54, Fabio Estevam wrote: Hi Dirk, On Thu, Apr 26, 2012 at 3:04 AM, Dirk Behme wrote: We had this patch on a v2012.04.1 based test branch and it showed some strange issues with SD cards on i.MX6. Depending on the SD card used (different ones) and the board (Sabre

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Fabio Estevam
Dirk, On Sun, Apr 29, 2012 at 11:54 AM, Fabio Estevam wrote: > Thanks for testing it. I found one mistake and will submit a fix shortly. Here is one issue I found: --- a/arch/arm/cpu/armv7/imx-common/cpu.c +++ b/arch/arm/cpu/armv7/imx-common/cpu.c @@ -147,6 +147,4 @@ u32 get_ahb_clk(void)

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-29 Thread Fabio Estevam
Hi Dirk, On Thu, Apr 26, 2012 at 3:04 AM, Dirk Behme wrote: > We had this patch on a v2012.04.1 based test branch and it showed some > strange issues with SD cards on i.MX6. > > Depending on the SD card used (different ones) and the board (SabreLite and > a custom one) > > - the SD card just wor

Re: [U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-04-25 Thread Dirk Behme
Hi Fabio, On 20.03.2012 22:40, Fabio Estevam wrote: get_ahb_clk() is a common function between mx5 and mx6. Place it into imx-common directory. Signed-off-by: Fabio Estevam --- arch/arm/cpu/armv7/imx-common/cpu.c| 23 arch/arm/cpu/armv7/mx5/clock.c

[U-Boot] [PATCH 2/5] imx-common: Factor out get_ahb_clk()

2012-03-20 Thread Fabio Estevam
get_ahb_clk() is a common function between mx5 and mx6. Place it into imx-common directory. Signed-off-by: Fabio Estevam --- arch/arm/cpu/armv7/imx-common/cpu.c| 23 arch/arm/cpu/armv7/mx5/clock.c | 17 +- arch/arm/cpu/arm