Re: [U-Boot] [PATCH 2/6] add a generic set of configs to enable Distros to more easier support u-boot based systems

On 12/17/2013 12:16 AM, Dennis Gilmore wrote: > diff --git a/include/common.h b/include/common.h > #include > #include > > +/* use generic distro config */ > +#ifdef DISTRO_DEFAULTS > +#include > +#endif There is another issue with including this header at this location: This include is

Re: [U-Boot] [PATCH 2/6] add a generic set of configs to enable Distros to more easier support u-boot based systems

On 12/17/2013 12:16 AM, Dennis Gilmore wrote: > diff --git a/include/config_distro_default.h b/include/config_distro_default.h > +#define CONFIG_CMD_EXT2 > +#define CONFIG_CMD_EXT4 > +#define CONFIG_CMD_FAT For a generic config, I would be tempted to drop the fs-specific command sets enabled by

Re: [U-Boot] [PATCH 2/6] add a generic set of configs to enable Distros to more easier support u-boot based systems

On 12/17/2013 12:16 AM, Dennis Gilmore wrote: > Signed-off-by: Dennis Gilmore Nit: A patch description might be useful; e.g. to describe that distros need to know that the bootloader enables a common set of options they can rely on, and this file is the definition of that set. > diff --git a/inc

[U-Boot] [PATCH 2/6] add a generic set of configs to enable Distros to more easier support u-boot based systems

Signed-off-by: Dennis Gilmore --- include/common.h| 5 include/config_distro_default.h | 55 + 2 files changed, 60 insertions(+) create mode 100644 include/config_distro_default.h diff --git a/include/common.h b/include/common.h inde