Re: [U-Boot] [PATCH 3/3] ti: common: board_detect: Return a valid empty string for un-initialized eeprom

2016-10-13 Thread Tom Rini
On Tue, Oct 11, 2016 at 12:39:05PM -0500, Nishanth Menon wrote: > Current logic for query of revision, board_name, config returns > NULL. Users of these functions do a direct strncmp to compare. > Unfortunately, as per conventions require two valid strings to compare > against and the current

Re: [U-Boot] [PATCH 3/3] ti: common: board_detect: Return a valid empty string for un-initialized eeprom

2016-10-12 Thread Lokesh Vutla
On Tuesday 11 October 2016 11:09 PM, Nishanth Menon wrote: > Current logic for query of revision, board_name, config returns > NULL. Users of these functions do a direct strncmp to compare. > Unfortunately, as per conventions require two valid strings to compare > against and the current

[U-Boot] [PATCH 3/3] ti: common: board_detect: Return a valid empty string for un-initialized eeprom

2016-10-11 Thread Nishanth Menon
Current logic for query of revision, board_name, config returns NULL. Users of these functions do a direct strncmp to compare. Unfortunately, as per conventions require two valid strings to compare against and the current implementation causes a crash when compared with NULL. We'd still like to