Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-29 Thread Tom Rini
On Thu, Oct 29, 2015 at 09:17:04AM +, Ryan Harkin wrote: > Hi Tom, > > On 28 October 2015 at 22:07, Tom Rini wrote: > > On Wed, Oct 28, 2015 at 10:43:41PM +0100, Linus Walleij wrote: > >> On Wed, Oct 28, 2015 at 5:06 PM, Ryan Harkin > >> wrote: > >> > >> > For reasons I don't understand, en

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-29 Thread Ryan Harkin
Hi Tom, On 28 October 2015 at 22:07, Tom Rini wrote: > On Wed, Oct 28, 2015 at 10:43:41PM +0100, Linus Walleij wrote: >> On Wed, Oct 28, 2015 at 5:06 PM, Ryan Harkin wrote: >> >> > For reasons I don't understand, envcrc.c includes config.h which >> > includes vexpress64_aemv8a.h without the boar

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-28 Thread Tom Rini
On Wed, Oct 28, 2015 at 10:43:41PM +0100, Linus Walleij wrote: > On Wed, Oct 28, 2015 at 5:06 PM, Ryan Harkin wrote: > > > For reasons I don't understand, envcrc.c includes config.h which > > includes vexpress64_aemv8a.h without the board #defines set at all, no > > matter which board you are. S

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-28 Thread Linus Walleij
On Wed, Oct 28, 2015 at 5:06 PM, Ryan Harkin wrote: > For reasons I don't understand, envcrc.c includes config.h which > includes vexpress64_aemv8a.h without the board #defines set at all, no > matter which board you are. So the #error gets hit no matter if > you're building for FVP or Juno. Th

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-28 Thread Ryan Harkin
On 28 October 2015 at 15:10, Linus Walleij wrote: > On Wed, Oct 28, 2015 at 4:07 PM, Ryan Harkin wrote: >> On 27 October 2015 at 21:39, Linus Walleij wrote: >>> On Tue, Oct 27, 2015 at 1:49 PM, Ryan Harkin wrote: >>> Either way, AFAIK, the existing CFI code does not handle AFS support. >>>

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-28 Thread Linus Walleij
On Wed, Oct 28, 2015 at 4:07 PM, Ryan Harkin wrote: > On 27 October 2015 at 21:39, Linus Walleij wrote: >> On Tue, Oct 27, 2015 at 1:49 PM, Ryan Harkin wrote: >> >>> Either way, AFAIK, the existing CFI code does not handle AFS support. >>> I think the CFI code would need extending to write the f

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-28 Thread Ryan Harkin
On 27 October 2015 at 21:39, Linus Walleij wrote: > On Tue, Oct 27, 2015 at 1:49 PM, Ryan Harkin wrote: > >> Either way, AFAIK, the existing CFI code does not handle AFS support. >> I think the CFI code would need extending to write the footer if we >> wanted the afs command to show the config in

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-27 Thread Linus Walleij
On Tue, Oct 27, 2015 at 1:49 PM, Ryan Harkin wrote: > Either way, AFAIK, the existing CFI code does not handle AFS support. > I think the CFI code would need extending to write the footer if we > wanted the afs command to show the config in another way. Could that > be what Peter Pearse did? Uh

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-27 Thread Ryan Harkin
Hi Linus, On 27 October 2015 at 11:49, Linus Walleij wrote: > On Wed, Oct 21, 2015 at 11:54 AM, Ryan Harkin wrote: > >> Juno has 1 flash part with 259 sectors. The first 255 sectors are >> 0x4 (256kb) and are followed by 4 sectors of 0x1 (64KB). >> >> FVP models simulate a 64MB NOR flas

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-27 Thread Linus Walleij
On Wed, Oct 21, 2015 at 11:54 AM, Ryan Harkin wrote: > Juno has 1 flash part with 259 sectors. The first 255 sectors are > 0x4 (256kb) and are followed by 4 sectors of 0x1 (64KB). > > FVP models simulate a 64MB NOR flash part at base address 0x0FFC. > This part has 256 x 256kb sector

[U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-21 Thread Ryan Harkin
Add support for storing the environment in CFI NOR flash on Juno and FVP models. I also removed some config values that are not used by CFI flash parts. Juno has 1 flash part with 259 sectors. The first 255 sectors are 0x4 (256kb) and are followed by 4 sectors of 0x1 (64KB). FVP models