Re: [U-Boot] [PATCH 3/3 v8] mmc: add generic mmc spi driver

2010-07-05 Thread Mike Frysinger
On Wednesday, May 19, 2010 00:37:47 Thomas Chou wrote: --- /dev/null +++ b/common/cmd_mmc_spi.c + printf(%s: %d at %u:%u %u %u\n, mmc-name, mmc-block_dev.dev, +bus, cs, speed, mode); this is a bit terse. how about prefixing the hz output with like hz: and the mode with like

Re: [U-Boot] [PATCH 3/3 v8] mmc: add generic mmc spi driver

2010-07-05 Thread Thomas Chou
Hi Mike, Thank you very much for the review and testing. On 07/05/2010 03:40 PM, Mike Frysinger wrote: On Wednesday, May 19, 2010 00:37:47 Thomas Chou wrote: --- /dev/null +++ b/common/cmd_mmc_spi.c +printf(%s: %d at %u:%u %u %u\n, mmc-name, mmc-block_dev.dev, + bus, cs,

Re: [U-Boot] [PATCH 3/3 v8] mmc: add generic mmc spi driver

2010-07-05 Thread Mike Frysinger
On Monday, July 05, 2010 10:22:45 Thomas Chou wrote: On 07/05/2010 03:40 PM, Mike Frysinger wrote: On Wednesday, May 19, 2010 00:37:47 Thomas Chou wrote: --- /dev/null +++ b/drivers/mmc/mmc_spi.c +struct mmc *mmc_spi_init(uint bus, uint cs, uint speed, uint mode) +{ + struct mmc

Re: [U-Boot] [PATCH 3/3 v8] mmc: add generic mmc spi driver

2010-05-28 Thread Thomas Chou
Hi Andy, Would you please review these patches? 05/03 [PATCH 1/3] lib: add crc7 from Linux 05/19 [PATCH 3/3 v8] mmc: add generic mmc spi driver Best regards, Thomas ___ U-Boot mailing list U-Boot@lists.denx.de

[U-Boot] [PATCH 3/3 v8] mmc: add generic mmc spi driver

2010-05-18 Thread Thomas Chou
This patch supports mmc/sd card with spi interface. It is based on the generic mmc framework. It works with SDHC and supports multi blocks read/write. The crc checksum on data packet is enabled with the def, #define CONFIG_MMC_SPI_CRC_ON There is a subcomamnd mmc_spi to setup spi bus and cs at