Re: [U-Boot] [PATCH 3/4] fs: prevent overwriting reserved memory

2018-11-16 Thread Heinrich Schuchardt
On 11/16/18 7:48 AM, Simon Goldschmidt wrote: > On 14.11.2018 00:03, Heinrich Schuchardt wrote: >> On 11/13/18 10:47 PM, Simon Goldschmidt wrote: >>> >>> Am Di., 13. Nov. 2018, 22:37 hat Heinrich Schuchardt >> > geschrieben: >>> >>> On 11/13/18 9:01 PM, Simon

Re: [U-Boot] [PATCH 3/4] fs: prevent overwriting reserved memory

2018-11-15 Thread Simon Goldschmidt
On 14.11.2018 00:03, Heinrich Schuchardt wrote: On 11/13/18 10:47 PM, Simon Goldschmidt wrote: Am Di., 13. Nov. 2018, 22:37 hat Heinrich Schuchardt mailto:xypron.g...@gmx.de>> geschrieben: On 11/13/18 9:01 PM, Simon Goldschmidt wrote: > On 13.11.2018 20:42, Heinrich Schuchardt

Re: [U-Boot] [PATCH 3/4] fs: prevent overwriting reserved memory

2018-11-13 Thread Heinrich Schuchardt
On 11/13/18 10:47 PM, Simon Goldschmidt wrote: > > > Am Di., 13. Nov. 2018, 22:37 hat Heinrich Schuchardt > geschrieben: > > On 11/13/18 9:01 PM, Simon Goldschmidt wrote: > > On 13.11.2018 20:42, Heinrich Schuchardt wrote: > >> On 11/13/18 6:47 AM, Simon

Re: [U-Boot] [PATCH 3/4] fs: prevent overwriting reserved memory

2018-11-13 Thread Simon Goldschmidt
Am Di., 13. Nov. 2018, 22:37 hat Heinrich Schuchardt geschrieben: > On 11/13/18 9:01 PM, Simon Goldschmidt wrote: > > On 13.11.2018 20:42, Heinrich Schuchardt wrote: > >> On 11/13/18 6:47 AM, Simon Goldschmidt wrote: > >>> On Tue, Nov 13, 2018 at 3:23 AM Fabio Estevam > >>> wrote: > Hi

Re: [U-Boot] [PATCH 3/4] fs: prevent overwriting reserved memory

2018-11-13 Thread Heinrich Schuchardt
On 11/13/18 9:01 PM, Simon Goldschmidt wrote: > On 13.11.2018 20:42, Heinrich Schuchardt wrote: >> On 11/13/18 6:47 AM, Simon Goldschmidt wrote: >>> On Tue, Nov 13, 2018 at 3:23 AM Fabio Estevam >>> wrote: Hi Simon, On Mon, Nov 12, 2018 at 7:25 PM Simon Goldschmidt wrote:

Re: [U-Boot] [PATCH 3/4] fs: prevent overwriting reserved memory

2018-11-13 Thread Simon Goldschmidt
On 13.11.2018 20:42, Heinrich Schuchardt wrote: On 11/13/18 6:47 AM, Simon Goldschmidt wrote: On Tue, Nov 13, 2018 at 3:23 AM Fabio Estevam wrote: Hi Simon, On Mon, Nov 12, 2018 at 7:25 PM Simon Goldschmidt wrote: diff --git a/fs/fs.c b/fs/fs.c index adae98d021..4baf6b1c39 100644 ---

Re: [U-Boot] [PATCH 3/4] fs: prevent overwriting reserved memory

2018-11-13 Thread Heinrich Schuchardt
On 11/13/18 6:47 AM, Simon Goldschmidt wrote: > On Tue, Nov 13, 2018 at 3:23 AM Fabio Estevam wrote: >> >> Hi Simon, >> >> On Mon, Nov 12, 2018 at 7:25 PM Simon Goldschmidt >> wrote: >> >>> diff --git a/fs/fs.c b/fs/fs.c >>> index adae98d021..4baf6b1c39 100644 >>> --- a/fs/fs.c >>> +++ b/fs/fs.c

Re: [U-Boot] [PATCH 3/4] fs: prevent overwriting reserved memory

2018-11-12 Thread Simon Goldschmidt
On Tue, Nov 13, 2018 at 3:23 AM Fabio Estevam wrote: > > Hi Simon, > > On Mon, Nov 12, 2018 at 7:25 PM Simon Goldschmidt > wrote: > > > diff --git a/fs/fs.c b/fs/fs.c > > index adae98d021..4baf6b1c39 100644 > > --- a/fs/fs.c > > +++ b/fs/fs.c > > @@ -428,13 +428,57 @@ int fs_size(const char

Re: [U-Boot] [PATCH 3/4] fs: prevent overwriting reserved memory

2018-11-12 Thread Fabio Estevam
Hi Simon, On Mon, Nov 12, 2018 at 7:25 PM Simon Goldschmidt wrote: > diff --git a/fs/fs.c b/fs/fs.c > index adae98d021..4baf6b1c39 100644 > --- a/fs/fs.c > +++ b/fs/fs.c > @@ -428,13 +428,57 @@ int fs_size(const char *filename, loff_t *size) > return ret; > } > > -int fs_read(const

[U-Boot] [PATCH 3/4] fs: prevent overwriting reserved memory

2018-11-12 Thread Simon Goldschmidt
This fixes CVE-2018-18440 ("insufficient boundary checks in filesystem image load") by using lmb to check the load size of a file against reserved memory addresses. Signed-off-by: Simon Goldschmidt --- fs/fs.c | 56 --- include/lmb.h | 2