[U-Boot] [PATCH 3/7] JFFS2: Calculate buf_len before we read data from flash

2011-04-23 Thread Baidu Liu
1/ We should calculate the buf_len before we call get_fl_mem(). Signed-off-by: Baidu Liu --- fs/jffs2/jffs2_1pass.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/fs/jffs2/jffs2_1pass.c b/fs/jffs2/jffs2_1pass.c index 8eb77b1..be6ac78 100644 --- a/fs/jffs2/j

Re: [U-Boot] [PATCH 3/7] JFFS2: Calculate buf_len before we read data from flash

2011-04-29 Thread Detlev Zundel
Hi Baidu, > 1/ We should calculate the buf_len before we call > get_fl_mem(). If I read your change correctly, then do you mean the following? When we know what we want to read, we can calculate buf_len to be the maximum size of the data to be read. Without this, we usually read EMPTY_S

Re: [U-Boot] [PATCH 3/7] JFFS2: Calculate buf_len before we read data from flash

2011-04-29 Thread Baidu Liu
Hi,Detlev 2011/4/29 Detlev Zundel : > Hi Baidu, > >>  1/ We should calculate the buf_len before we call >>  get_fl_mem(). > > If I read your change correctly, then do you mean the following? > >  When we know what we want to read, we can calculate buf_len to be the >  maximum size of the data to b

Re: [U-Boot] [PATCH 3/7] JFFS2: Calculate buf_len before we read data from flash

2011-04-29 Thread Baidu Liu
Hi,Detlev 2011/4/29 Detlev Zundel : > Hi Baidu, > >>  1/ We should calculate the buf_len before we call >>  get_fl_mem(). > > If I read your change correctly, then do you mean the following? > >  When we know what we want to read, we can calculate buf_len to be the >  maximum size of the data to b

Re: [U-Boot] [PATCH 3/7] JFFS2: Calculate buf_len before we read data from flash

2011-04-29 Thread Detlev Zundel
Hi Baidu, [...] >>> diff --git a/fs/jffs2/jffs2_1pass.c b/fs/jffs2/jffs2_1pass.c >>> index 8eb77b1..be6ac78 100644 >>> --- a/fs/jffs2/jffs2_1pass.c >>> +++ b/fs/jffs2/jffs2_1pass.c >>> @@ -1643,6 +1643,8 @@ jffs2_1pass_build_lists(struct part_info * part) >>>                       case JFFS2_NODE

Re: [U-Boot] [PATCH 3/7] JFFS2: Calculate buf_len before we read data from flash

2011-04-29 Thread Baidu Liu
Hi, Detlev : 2011/4/30 Detlev Zundel : > Hi Baidu, > > [...] > diff --git a/fs/jffs2/jffs2_1pass.c b/fs/jffs2/jffs2_1pass.c index 8eb77b1..be6ac78 100644 --- a/fs/jffs2/jffs2_1pass.c +++ b/fs/jffs2/jffs2_1pass.c @@ -1643,6 +1643,8 @@ jffs2_1pass_build_lists(struct part_inf

Re: [U-Boot] [PATCH 3/7] JFFS2: Calculate buf_len before we read data from flash

2011-05-02 Thread Detlev Zundel
Hi Baidu, > Hi, Detlev : > > 2011/4/30 Detlev Zundel : >> Hi Baidu, >> >> [...] >> > diff --git a/fs/jffs2/jffs2_1pass.c b/fs/jffs2/jffs2_1pass.c > index 8eb77b1..be6ac78 100644 > --- a/fs/jffs2/jffs2_1pass.c > +++ b/fs/jffs2/jffs2_1pass.c > @@ -1643,6 +1643,8 @@ jffs2_1pass_bu