Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-26 Thread Haiying Wang
Dear Wolfgang, On Mon, 2011-01-24 at 23:29 +0100, Wolfgang Denk wrote: Dear Haiying Wang, In message 1295907459.2051.158.camel@haiying-laptop you wrote: It's not the name. But you use it ina few places here, buth then hard encode tpl in a number of other paces there. Which means

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-26 Thread Wolfgang Denk
Dear Haiying Wang, In message 1296076056.1985.47.camel@haiying-laptop you wrote: I fixed the NAND_SPL in this way. If it is OK for you, I will generate the patches accordingly for TPL as well. Thanks. BTW, the ./MAKEALL powerpc worked for my previous patch. This looks good to me. Thanks

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-24 Thread Wolfgang Denk
Dear Haiying Wang, In message 1295842861.2196.38.camel@haiying-laptop you wrote: On Sat, 2011-01-22 at 23:04 +0100, Wolfgang Denk wrote: diff --git a/Makefile b/Makefile index 87a383d..94af465 100644 --- a/Makefile +++ b/Makefile @@ -290,6 +290,10 @@ LDPPFLAGS += \ $(shell

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-24 Thread Scott Wood
On Mon, 24 Jan 2011 13:49:19 +0100 Wolfgang Denk w...@denx.de wrote: + CONFIG_TPL_U_BOOT + + Builds a U-Boot image that contains a loader stub (tertiary + program loader -- TPL) that boots out of some type of RAM, +

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-24 Thread Wolfgang Denk
Dear Scott Wood, In message 20110124133835.5b26b...@udp111988uds.am.freescale.net you wrote: Now, the naming could be clearer. Changing CONFIG_TPL_BOOT into CONFIG_TPL would make it look more like the existing SPL names. Or we could do something like: CONFIG_HAS_SPL /* set in all of

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-24 Thread Wolfgang Denk
Dear Haiying Wang, In message 1295906076.2051.127.camel@haiying-laptop you wrote: What I do not understand is what the TPL_BOOT variable in the Makefile is good for. I cannot understand the current use. Well, it was used to generate the tpl image under tpl/ directory. Maybe TPL_BOOT is

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-24 Thread Haiying Wang
On Mon, 2011-01-24 at 13:49 +0100, Wolfgang Denk wrote: +ifeq ($(CONFIG_TPL_U_BOOT),y) +TPL_BOOT = tpl +endif I don't understand what the TPL_BOOT is good for, or how it's supposed to work. TPL_BOOT works like NAND_SPL but after NAND_SPL is executed. It is a middle

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-24 Thread Haiying Wang
On Mon, 2011-01-24 at 23:09 +0100, Wolfgang Denk wrote: Dear Haiying Wang, In message 1295906076.2051.127.camel@haiying-laptop you wrote: What I do not understand is what the TPL_BOOT variable in the Makefile is good for. I cannot understand the current use. Well, it was used to

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-24 Thread Wolfgang Denk
Dear Haiying Wang, In message 1295907459.2051.158.camel@haiying-laptop you wrote: It's not the name. But you use it ina few places here, buth then hard encode tpl in a number of other paces there. Which means that you cannot change TPL_BOOT to any other value, or building would break.

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-24 Thread Scott Wood
On Mon, 24 Jan 2011 23:29:45 +0100 Wolfgang Denk w...@denx.de wrote: Dear Haiying Wang, In message 1295907459.2051.158.camel@haiying-laptop you wrote: It's not the name. But you use it ina few places here, buth then hard encode tpl in a number of other paces there. Which means that

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-23 Thread Haiying Wang
On Sat, 2011-01-22 at 23:04 +0100, Wolfgang Denk wrote: diff --git a/Makefile b/Makefile index 87a383d..94af465 100644 --- a/Makefile +++ b/Makefile @@ -290,6 +290,10 @@ LDPPFLAGS += \ $(shell $(LD) --version | \ sed -ne 's/GNU ld version

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-22 Thread Wolfgang Denk
Dear haiying.w...@freescale.com, In message 1291217737-3870-4-git-send-email-haiying.w...@freescale.com you wrote: From: Haiying Wang haiying.w...@freescale.com TPL is introduced to enable a loader stub that boots out of some type of RAM, after being loaded by an SPL or similar

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-22 Thread Wolfgang Denk
Dear Kumar Gala, In message be116222-9427-4216-9cae-00e3a4b14...@kernel.crashing.org you wrote: Did you plan on review this patch? Just done - I wonder if this code has ever been tested at all? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev

Re: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2011-01-21 Thread Kumar Gala
On Dec 1, 2010, at 9:35 AM, haiying.w...@freescale.com haiying.w...@freescale.com wrote: From: Haiying Wang haiying.w...@freescale.com TPL is introduced to enable a loader stub that boots out of some type of RAM, after being loaded by an SPL or similar platform-specific mechanism. One

[U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader

2010-12-01 Thread Haiying.Wang
From: Haiying Wang haiying.w...@freescale.com TPL is introduced to enable a loader stub that boots out of some type of RAM, after being loaded by an SPL or similar platform-specific mechanism. One example of using this tpl loader is to initialize the ddr through spd code in case the L2 SRAM size