[U-Boot] [PATCH 3/9 v2] Exynos: pwm: Fix two bugs in the exynos pwm configuration code

2013-02-28 Thread Akshay Saraswat
First, the "div" value was being used incorrectly to compute the frequency of the PWM timer. The value passed in is a constant which reflects the value that would be found in a configuration register, 0 to 4. That should correspond to a scaling factor of 1, 2, 4, 8, or 16, 1 << div, but div + 1 was

Re: [U-Boot] [PATCH 3/9 v2] Exynos: pwm: Fix two bugs in the exynos pwm configuration code

2013-03-27 Thread Minkyu Kang
Dear Akshay, On 28/02/13 19:59, Akshay Saraswat wrote: > First, the "div" value was being used incorrectly to compute the frequency of > the PWM timer. The value passed in is a constant which reflects the value > that would be found in a configuration register, 0 to 4. That should > correspond to

Re: [U-Boot] [PATCH 3/9 v2] Exynos: pwm: Fix two bugs in the exynos pwm configuration code

2013-03-28 Thread Akshay Saraswat
Hi Minkyu, Thanks for your comments. >Dear Akshay, > >On 28/02/13 19:59, Akshay Saraswat wrote: >> First, the "div" value was being used incorrectly to compute the frequency of >> the PWM timer. The value passed in is a constant which reflects the value >> that would be found in a configuration r