Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-05-16 Thread Eugeniu Rosca
On Thu, May 16, 2019 at 5:14 PM Matthias Brugger wrote: > On 30/04/2019 21:07, Heinrich Schuchardt wrote: > > > > I think we should have a u-class for hardware RNGs as one source of entropy. > > Anyone working on this already? Not me. > If not I can have a look. green_light_on(); // :) > It

Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-05-16 Thread Matthias Brugger
On 30/04/2019 21:07, Heinrich Schuchardt wrote: > On 4/30/19 4:53 AM, Eugeniu Rosca wrote: >> The random uuid values (enabled via CONFIG_RANDOM_UUID=y) on our >> platform are always the same. Below is consistent on each cold boot: >> >>   => ### interrupt autoboot >>   => env default -a; gpt

Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-05-07 Thread Eugeniu Rosca
On Fri, May 03, 2019 at 06:09:28PM +0200, Eugeniu Rosca wrote: > On Thu, May 02, 2019 at 12:32:53AM +0200, Eugeniu Rosca wrote: > > Hi Tom, > > > > On Wed, May 01, 2019 at 03:51:49PM -0400, Tom Rini wrote: > > [..] > > > > > > Agreed, this patch sounds like it addresses a number of problems

Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-05-03 Thread Eugeniu Rosca
On Thu, May 02, 2019 at 12:32:53AM +0200, Eugeniu Rosca wrote: > Hi Tom, > > On Wed, May 01, 2019 at 03:51:49PM -0400, Tom Rini wrote: > [..] > > > > Agreed, this patch sounds like it addresses a number of problems today > > that are real problems (I await someone filing a CVE now for our PRNG >

Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-05-01 Thread Eugeniu Rosca
Hi Tom, On Wed, May 01, 2019 at 03:51:49PM -0400, Tom Rini wrote: [..] > > Agreed, this patch sounds like it addresses a number of problems today > that are real problems (I await someone filing a CVE now for our PRNG > problem) A new CVE has been submitted via https://cveform.mitre.org/. Will

Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-05-01 Thread Tom Rini
On Wed, May 01, 2019 at 09:08:31PM +0200, Eugeniu Rosca wrote: > Hi Heinrich, > > Thank you for reviewing this series. > > On Tue, Apr 30, 2019 at 09:07:09PM +0200, Heinrich Schuchardt wrote: > [..] > > This patch may ameliorate the situation for GUIDs a bit. But I dislike: > > In general, we

Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-05-01 Thread Eugeniu Rosca
Hi Heinrich, Thank you for reviewing this series. On Tue, Apr 30, 2019 at 09:07:09PM +0200, Heinrich Schuchardt wrote: [..] > This patch may ameliorate the situation for GUIDs a bit. But I dislike: In general, we can find reasons to dislike anything, since there is room for improvement in

Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-04-30 Thread Heinrich Schuchardt
On 4/30/19 4:53 AM, Eugeniu Rosca wrote: The random uuid values (enabled via CONFIG_RANDOM_UUID=y) on our platform are always the same. Below is consistent on each cold boot: => ### interrupt autoboot => env default -a; gpt write mmc 1 $partitions; print uuid_gpt_misc ...

[U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-04-29 Thread Eugeniu Rosca
The random uuid values (enabled via CONFIG_RANDOM_UUID=y) on our platform are always the same. Below is consistent on each cold boot: => ### interrupt autoboot => env default -a; gpt write mmc 1 $partitions; print uuid_gpt_misc ... uuid_gpt_misc=d117f98e-6f2c-d04b-a5b2-331a19f91cb2 => env