Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-09-12 Thread Wolfgang Denk
Dear Wolfgang Denk, In message <1279395948-25864-6-git-send-email...@denx.de> you wrote: > Motivation: > > * Old environment code used a pessimizing implementation: > - variable lookup used linear search => slow > - changed/added variables were added at the end, i. e. most > frequently us

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-08-03 Thread Wolfgang Denk
Dear Matthias Fuchs, In message <201007291116.15503.matthias.fu...@esd-electronics.com> you wrote: > > > Actually neither MAC addresses nor serial# are part of the default > > environment. > Right. But, I'd like to have that described feature in any case. Let's call > it different, > but the fu

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-29 Thread Matthias Fuchs
Hi Wolfgang, On Wednesday 28 July 2010 23:17, Wolfgang Denk wrote: > Dear Matthias Fuchs, > > In message <201007261652.39368.matthias.fu...@esd-electronics.com> you wrote: > > > > I could think of some situations where the new env command > > is helpful. But more during development than for prod

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-28 Thread Wolfgang Denk
Dear Matthias Fuchs, In message <201007261652.39368.matthias.fu...@esd-electronics.com> you wrote: > > I could think of some situations where the new env command > is helpful. But more during development than for production systems. It depends. "Reset to factory defaults" is a not so uncommon re

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-26 Thread Kim Phillips
On Sun, 25 Jul 2010 23:45:02 +0200 Wolfgang Denk wrote: > Could you please also test the code from the current (rebased) version > in the "hashtable" branch of the git://git.denx.de/u-boot-testing.git > repo? > > I have adresses the problem of early environment accesses, and at > least on the bo

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-26 Thread Matthias Fuchs
Hi Wolfgang, I could think of some situations where the new env command is helpful. But more during development than for production systems. Switching between environment profiles would be cool. And a "env default -f" behavior that keeps MAC addresses and serial# is also on my wishlist. I did so

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-25 Thread Wolfgang Denk
Dear Kim, In message <20100720170026.fee7f593.kim.phill...@freescale.com> you wrote: > > > Ah! Can you please try the following patch - it's not intended to be a > > fix, just to verify my hypothesis. Thanks in advance. > > indeed, your patch plus the following makes the 8572 boot properly > agai

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-20 Thread Kim Phillips
On Tue, 20 Jul 2010 23:43:14 +0200 Wolfgang Denk wrote: > Dear Kim, > > In message <20100720160808.b7ecf34c.kim.phill...@freescale.com> you wrote: > > > > > However, I cannot see any gentenv() use before relocation for your > > > board, so the problem there is still unclear. I think I need your

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-20 Thread Wolfgang Denk
Dear Kim, In message <20100720160808.b7ecf34c.kim.phill...@freescale.com> you wrote: > > > However, I cannot see any gentenv() use before relocation for your > > board, so the problem there is still unclear. I think I need your > > help to debug this... > > looks like arch/powerpc/cpu/mpc8xxx/dd

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-20 Thread Kim Phillips
On Tue, 20 Jul 2010 22:09:08 +0200 Wolfgang Denk wrote: > However, I cannot see any gentenv() use before relocation for your > board, so the problem there is still unclear. I think I need your > help to debug this... looks like arch/powerpc/cpu/mpc8xxx/ddr/options.c gets memory interleaving conf

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-20 Thread Wolfgang Denk
Dear Peter, In message <1279658019.5685.125.ca...@thunk> you wrote: > > > I think the problem is that before relocation we have to use > > getenv_r(), which is done for example to read the baudrate, see > > arch/powerpc/lib/board.c: init_baudrate() > > How hard is it to detect this case and gene

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-20 Thread Wolfgang Denk
Dear Kim, In message <20100720190112.3f435153...@gemini.denx.de> I wrote: > > What we see here is in the pre-relocation phase, where we are still > parsing the original, in-flash copy of the stringified environment. > What is strange is that this seems to have worked when accessing > "baudrate" (

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-20 Thread Wolfgang Denk
Dear Kim Phillips, In message <20100720133648.cbb95a9f.kim.phill...@freescale.com> you wrote: > > I would, however u-boot-testing.git/hashtable currently fails to boot > on an 8572: ... > I presume it's related to the issue brought up in this thread?: > > http://lists.denx.de/pipermail/u-boot/201

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-20 Thread Wolfgang Denk
Dear Kim Phillips, In message <20100720133648.cbb95a9f.kim.phill...@freescale.com> you wrote: > > I would, however u-boot-testing.git/hashtable currently fails to boot > on an 8572: Hm... one of the boards I don't have access to; can you please help debug the problem? > U-Boot 2010.06-02552-g989

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-20 Thread Kim Phillips
On Tue, 20 Jul 2010 11:40:23 +0200 Wolfgang Denk wrote: > Dear Kim Phillips, > > In message <20100719193825.120ebf29.kim.phill...@freescale.com> you wrote: > > > > > - It would be nice if we could add wildcard support for environment > > > variables; this is needed for variable name auto-compl

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-20 Thread Wolfgang Denk
Dear Kim Phillips, In message <20100719193825.120ebf29.kim.phill...@freescale.com> you wrote: > > > - It would be nice if we could add wildcard support for environment > > variables; this is needed for variable name auto-completion, > > but it would also be nice to be able to say "printenv ip*

Re: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables.

2010-07-19 Thread Kim Phillips
On Sat, 17 Jul 2010 21:45:48 +0200 Wolfgang Denk wrote: > - It would be nice if we could add wildcard support for environment > variables; this is needed for variable name auto-completion, > but it would also be nice to be able to say "printenv ip*" or > "printenv *addr*" you were right -