Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-05 Thread Igor Grinberg
On 07/05/11 00:24, Jason wrote: On Mon, Jul 04, 2011 at 04:32:35PM -0400, Christopher Harvey wrote: On Mon, Jul 04, 2011 at 04:13:49PM -0400, Jason wrote: On Mon, Jul 04, 2011 at 02:55:54PM -0400, Christopher Harvey wrote: On Mon, Jul 04, 2011 at 02:08:44PM -0400, Jason wrote: On Mon, Jul

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-05 Thread Igor Grinberg
On 07/04/11 23:32, Christopher Harvey wrote: On Mon, Jul 04, 2011 at 04:13:49PM -0400, Jason wrote: On Mon, Jul 04, 2011 at 02:55:54PM -0400, Christopher Harvey wrote: On Mon, Jul 04, 2011 at 02:08:44PM -0400, Jason wrote: On Mon, Jul 04, 2011 at 01:45:41PM -0400, Christopher Harvey wrote:

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-05 Thread Igor Grinberg
On 07/04/11 20:45, Christopher Harvey wrote: Signed-off-by: Christopher Harvey char...@matrox.com --- arch/arm/lib/board.c |4 arch/arm/lib/bootm.c |6 ++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-05 Thread Wolfgang Denk
Dear Igor Grinberg, In message 4e12bf5d.6080...@compulab.co.il you wrote: + debug(\nWarning: machid not set! Linux will not finish booting.\n\n); + } +#endif Is there a reason to close this in ifdef DEBUG? and also use debug()? I would print this in any case, because

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-05 Thread Igor Grinberg
On 07/05/11 13:04, Wolfgang Denk wrote: Dear Igor Grinberg, In message 4e12bf5d.6080...@compulab.co.il you wrote: + debug(\nWarning: machid not set! Linux will not finish booting.\n\n); + } +#endif Is there a reason to close this in ifdef DEBUG? and also use debug()? I

[U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-04 Thread Christopher Harvey
Signed-off-by: Christopher Harvey char...@matrox.com --- arch/arm/lib/board.c |4 arch/arm/lib/bootm.c |6 ++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 169dfeb..dbb835a 100644 --- a/arch/arm/lib/board.c +++

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-04 Thread Jason
On Mon, Jul 04, 2011 at 01:45:41PM -0400, Christopher Harvey wrote: Signed-off-by: Christopher Harvey char...@matrox.com --- arch/arm/lib/board.c |4 arch/arm/lib/bootm.c |6 ++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/lib/board.c

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-04 Thread Christopher Harvey
On Mon, Jul 04, 2011 at 02:08:44PM -0400, Jason wrote: On Mon, Jul 04, 2011 at 01:45:41PM -0400, Christopher Harvey wrote: Signed-off-by: Christopher Harvey char...@matrox.com --- arch/arm/lib/board.c |4 arch/arm/lib/bootm.c |6 ++ 2 files changed, 10 insertions(+), 0

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-04 Thread Wolfgang Denk
Dear Christopher Harvey, In message 20110704174541.gf3...@harvey-pc.matrox.com you wrote: Signed-off-by: Christopher Harvey char...@matrox.com --- arch/arm/lib/board.c |4 arch/arm/lib/bootm.c |6 ++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-04 Thread Wolfgang Denk
Dear Christopher Harvey, In message 20110704185554.gh3...@harvey-pc.matrox.com you wrote: On Mon, Jul 04, 2011 at 02:08:44PM -0400, Jason wrote: On Mon, Jul 04, 2011 at 01:45:41PM -0400, Christopher Harvey wrote: Signed-off-by: Christopher Harvey char...@matrox.com ---

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-04 Thread Jason
On Mon, Jul 04, 2011 at 02:55:54PM -0400, Christopher Harvey wrote: On Mon, Jul 04, 2011 at 02:08:44PM -0400, Jason wrote: On Mon, Jul 04, 2011 at 01:45:41PM -0400, Christopher Harvey wrote: +Hopefully there will never be this many machines. +Can't use 0 since 0 is already used

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-04 Thread Christopher Harvey
On Mon, Jul 04, 2011 at 04:13:49PM -0400, Jason wrote: On Mon, Jul 04, 2011 at 02:55:54PM -0400, Christopher Harvey wrote: On Mon, Jul 04, 2011 at 02:08:44PM -0400, Jason wrote: On Mon, Jul 04, 2011 at 01:45:41PM -0400, Christopher Harvey wrote: + Hopefully there will never be

Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

2011-07-04 Thread Jason
On Mon, Jul 04, 2011 at 04:32:35PM -0400, Christopher Harvey wrote: On Mon, Jul 04, 2011 at 04:13:49PM -0400, Jason wrote: On Mon, Jul 04, 2011 at 02:55:54PM -0400, Christopher Harvey wrote: On Mon, Jul 04, 2011 at 02:08:44PM -0400, Jason wrote: On Mon, Jul 04, 2011 at 01:45:41PM -0400,