Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-17 Thread Grant Likely
On Mon, Nov 17, 2014 at 10:14 AM, Ian Campbell wrote: > On Mon, 2014-11-17 at 09:58 +, Grant Likely wrote: >> I /DO/ want comments though. Putting the node in /chosen is >> unconventional. I want to hear if anyone has a good reason why the >> framebuffers shouldn't be placed into /chosen. > >

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-17 Thread Grant Likely
On Sun, Nov 16, 2014 at 4:11 PM, Ian Campbell wrote: > On Sun, 2014-11-16 at 16:11 +0100, Hans de Goede wrote: >> On 11/16/2014 03:38 PM, Ian Campbell wrote: >> > On Sun, 2014-11-16 at 14:52 +0100, Hans de Goede wrote: >> >> Hardcoding a path is deliberate. I don't know if you've read the >> >> pr

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-17 Thread Ian Campbell
On Mon, 2014-11-17 at 09:58 +, Grant Likely wrote: > I /DO/ want comments though. Putting the node in /chosen is > unconventional. I want to hear if anyone has a good reason why the > framebuffers shouldn't be placed into /chosen. I don't think putting it under /chosen is a problem at all. THe

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-17 Thread Hans de Goede
Hi, On 11/17/2014 10:58 AM, Grant Likely wrote: > On Sun, Nov 16, 2014 at 4:11 PM, Ian Campbell wrote: >> On Sun, 2014-11-16 at 16:11 +0100, Hans de Goede wrote: >>> Right, I forgot to add one important bit to my explanation, sorry, if >>> you look at the binding then it says that the name sho

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-16 Thread Hans de Goede
Hi, On 11/16/2014 06:19 PM, Ian Campbell wrote: > On Sun, 2014-11-16 at 16:11 +, Ian Campbell wrote: >> >>> AFAIK Grant agrees with v5 >> >> AFAIK Grant hasn't actually said that. If he does ack it (or if >> someone >> points me to the correct mail) then I have no further objections. > > I fi

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-16 Thread Ian Campbell
On Sun, 2014-11-16 at 16:11 +, Ian Campbell wrote: > > > AFAIK Grant agrees with v5 > > AFAIK Grant hasn't actually said that. If he does ack it (or if > someone > points me to the correct mail) then I have no further objections. I finally found which for some reason isn't in my devicetree@

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-16 Thread Ian Campbell
On Sun, 2014-11-16 at 16:11 +0100, Hans de Goede wrote: > Hi, > > On 11/16/2014 03:38 PM, Ian Campbell wrote: > > devicetree@, comments on the requirement that a node have a specific > > path welcomed. > > > > On Sun, 2014-11-16 at 14:52 +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 11/16/201

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-16 Thread Hans de Goede
Hi, On 11/16/2014 03:38 PM, Ian Campbell wrote: > devicetree@, comments on the requirement that a node have a specific > path welcomed. > > On Sun, 2014-11-16 at 14:52 +0100, Hans de Goede wrote: >> Hi, >> >> On 11/16/2014 12:50 PM, Ian Campbell wrote: >>> On Fri, 2014-11-14 at 17:54 +0100, Hans

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-16 Thread Ian Campbell
devicetree@, comments on the requirement that a node have a specific path welcomed. On Sun, 2014-11-16 at 14:52 +0100, Hans de Goede wrote: > Hi, > > On 11/16/2014 12:50 PM, Ian Campbell wrote: > > On Fri, 2014-11-14 at 17:54 +0100, Hans de Goede wrote: > >> From: Luc Verhaegen > >> > >> Add sim

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-16 Thread Hans de Goede
Hi, On 11/16/2014 12:50 PM, Ian Campbell wrote: > On Fri, 2014-11-14 at 17:54 +0100, Hans de Goede wrote: >> From: Luc Verhaegen >> >> Add simplefb support, note this depends on the kernel having support for >> the clocks property which has recently been added to the simplefb devicetree >> bindin

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-16 Thread Ian Campbell
On Fri, 2014-11-14 at 17:54 +0100, Hans de Goede wrote: > From: Luc Verhaegen > > Add simplefb support, note this depends on the kernel having support for > the clocks property which has recently been added to the simplefb devicetree > binding. Link please, Linus's tree[0] doesn't seem to have i

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-15 Thread Hans de Goede
Hi, On 11/14/2014 11:22 PM, Anatolij Gustschin wrote: > On Fri, 14 Nov 2014 17:54:47 +0100 > Hans de Goede wrote: > ... >> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h >> index 532fdb7..d7d8571 100644 >> --- a/include/configs/sunxi-common.h >> +++ b/include/configs

Re: [U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-14 Thread Anatolij Gustschin
On Fri, 14 Nov 2014 17:54:47 +0100 Hans de Goede wrote: ... > diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h > index 532fdb7..d7d8571 100644 > --- a/include/configs/sunxi-common.h > +++ b/include/configs/sunxi-common.h > @@ -204,6 +204,9 @@ > */ > #define CONFIG_SU

[U-Boot] [PATCH 5/6] sunxi: video: Add simplefb support

2014-11-14 Thread Hans de Goede
From: Luc Verhaegen Add simplefb support, note this depends on the kernel having support for the clocks property which has recently been added to the simplefb devicetree binding. Signed-off-by: Luc Verhaegen [hdego...@redhat.com: Use pre-populated simplefb node under /chosen as disussed on the