Re: [U-Boot] [PATCH 5/7] gpio-led: Fix __led_toggle support to first set GPIO as input

2013-09-28 Thread Eric Bénard
Hi Otavio, Le Sat, 28 Sep 2013 00:24:16 -0300, Otavio Salvador ota...@ossystems.com.br a écrit : The GPIO need to be set as input before reading its current value and set back to output for setting it; this fixes the non-working 'led id toggle' for GPIO based LEDs. Signed-off-by: Otavio

Re: [U-Boot] [PATCH 5/7] gpio-led: Fix __led_toggle support to first set GPIO as input

2013-09-28 Thread Fabio Estevam
On Sat, Sep 28, 2013 at 10:12 AM, Eric Bénard e...@eukrea.com wrote: Maybe the real fix would be to check why gpio_get_value doesn't return the level of the gpio when it's configured as an output. I agree with Eric. Could you please test the patch below? --- a/drivers/gpio/mxc_gpio.c +++

Re: [U-Boot] [PATCH 5/7] gpio-led: Fix __led_toggle support to first set GPIO as input

2013-09-28 Thread Otavio Salvador
On Sat, Sep 28, 2013 at 1:35 PM, Fabio Estevam feste...@gmail.com wrote: On Sat, Sep 28, 2013 at 10:12 AM, Eric Bénard e...@eukrea.com wrote: Maybe the real fix would be to check why gpio_get_value doesn't return the level of the gpio when it's configured as an output. I agree with Eric.

[U-Boot] [PATCH 5/7] gpio-led: Fix __led_toggle support to first set GPIO as input

2013-09-27 Thread Otavio Salvador
The GPIO need to be set as input before reading its current value and set back to output for setting it; this fixes the non-working 'led id toggle' for GPIO based LEDs. Signed-off-by: Otavio Salvador ota...@ossystems.com.br --- drivers/misc/gpio_led.c | 3 ++- 1 file changed, 2 insertions(+), 1