Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-26 Thread York Sun
On Fri, 2011-08-26 at 20:12 +0200, Wolfgang Denk wrote: > Dear York Sun, > > In message <1314378058.20734.25.camel@oslab-l1> you wrote: > > > > I am going to follow the style and not to add new typedefs. For the > > existing typedef, I will keep using them. In this case, it is an > > existing typ

Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-26 Thread Wolfgang Denk
Dear York Sun, In message <1314378058.20734.25.camel@oslab-l1> you wrote: > > I am going to follow the style and not to add new typedefs. For the > existing typedef, I will keep using them. In this case, it is an > existing typedef, just for another platform. Fixing it alone will cause > more tro

Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-26 Thread York Sun
Wolfgang, On Fri, 2011-08-26 at 00:31 +0200, Wolfgang Denk wrote: > Dear York Sun, > > In message <1314308192.29220.29.camel@oslab-l1> you wrote: > > > > I am introducing it to this file as it is already being used somewhere > > else. If you are trying to enforce this new policy, please start wi

Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-25 Thread Wolfgang Denk
Dear York Sun, In message <1314308192.29220.29.camel@oslab-l1> you wrote: > > I am introducing it to this file as it is already being used somewhere > else. If you are trying to enforce this new policy, please start with > brand new files/typedefs, as you pointed out in my another patch. I will >

Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-25 Thread York Sun
Wolfgang, On Thu, 2011-08-25 at 23:30 +0200, Wolfgang Denk wrote: > Dear York Sun, > > In message <1314307500.29220.24.camel@oslab-l1> you wrote: > > > > Fixing all existing reference to ccs_ddr is a lot of work, comparing > > with defining it for 83xx. There are many other typedefs in the very >

Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-25 Thread Wolfgang Denk
Dear York Sun, In message <1314307500.29220.24.camel@oslab-l1> you wrote: > > Fixing all existing reference to ccs_ddr is a lot of work, comparing > with defining it for 83xx. There are many other typedefs in the very > same files. Would we fix all of them? I don't think so. The bottom of well, i

Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-25 Thread York Sun
On Thu, 2011-08-25 at 23:20 +0200, Wolfgang Denk wrote: > Dear York Sun, > > In message <1314305821.29220.21.camel@oslab-l1> you wrote: > > > > > WARNING: do not add new typedefs > > > #408: FILE: arch/powerpc/include/asm/immap_83xx.h:289: > > > +typedef struct ccsr_ddr { > > > > > > Please fix.

Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-25 Thread Wolfgang Denk
Dear York Sun, In message <1314305821.29220.21.camel@oslab-l1> you wrote: > > > WARNING: do not add new typedefs > > #408: FILE: arch/powerpc/include/asm/immap_83xx.h:289: > > +typedef struct ccsr_ddr { > > > > Please fix. > > I can fix the new tyepdef. But this one isn't. It has been used for

Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-25 Thread York Sun
Wolfgang, On Thu, 2011-08-25 at 00:36 +0200, Wolfgang Denk wrote: > Dear York Sun, > > In message <1312923045-2612-5-git-send-email-york...@freescale.com> you wrote: > > Unified DDR driver is maintained for better performance, robustness and bug > > fixes. Upgrading to use unified DDR driver for

Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-24 Thread Wolfgang Denk
Dear York Sun, In message <1312923045-2612-5-git-send-email-york...@freescale.com> you wrote: > Unified DDR driver is maintained for better performance, robustness and bug > fixes. Upgrading to use unified DDR driver for MPC83xx takes advantage of > overall improvement. It requires changes for boa

[U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-09 Thread York Sun
Unified DDR driver is maintained for better performance, robustness and bug fixes. Upgrading to use unified DDR driver for MPC83xx takes advantage of overall improvement. It requires changes for board files to customize platform-dependent parameters. To utilize the unified DDR driver, a board need