Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-23 Thread Lee Jones
> > Ideally I'd like to keep it all as data, as it will save lots of > > text parsing code in the kernel. Surely there must be a call for > > passing data structures from the bootloader to the kernel. After > > all, that's why ATAGs were brought about wasn't it? > > Look at which ATAGS exist to se

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-22 Thread Wolfgang Denk
Dear Lee Jones, In message <20121122160847.gd10...@gmail.com> you wrote: > > Ideally I'd like to keep it all as data, as it will save lots of > text parsing code in the kernel. Surely there must be a call for > passing data structures from the bootloader to the kernel. After > all, that's why ATAG

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-22 Thread Lee Jones
> > Let's try to move this forward. > > Actually you don't. You insist on not changing anything on your side, > and ask others to adapt to it. Not at all. This current implementation is unacceptable to you and your counter- suggestion is unacceptable to me (and all other kernel engineers). I'm

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-22 Thread Wolfgang Denk
Dear Lee Jones, In message <20121122101433.ga4...@gmail.com> you wrote: > Let's try to move this forward. Actually you don't. You insist on not changing anything on your side, and ask others to adapt to it. > Okay, to summarise so far: > > 1. Bootloader and kernel mechanisms should be the same

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-22 Thread Lee Jones
Let's try to move this forward. > And it has to be implemented using a completely new method, because > all existing ones are crap or not the "correct way" to do it. We've > been there before. > I accept this, but please also accept that I ask you not to add > code that duplicates existing func

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Wolfgang Denk
Dear Lee Jones, In message <20121121174856.gc...@gmail.com> you wrote: > > > So far, the established way of passing logging information (like > > results of Power-On Selft Tests,e tc.) is through a shared log buffer. > > Also true, but is that data used in this way? Or is it just > printed out at

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Lee Jones
> > > If you are not interested in such information, then just use > > > appropriate log levels and filtering. > > > > I think the kernel log is the wrong place for this to go. Although, > > OK, this is your opinion, then, and I will respect it. Thank you, and I yours. > It is my opinion that m

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Wolfgang Denk
Dear Lee Jones, In message <20121121143928.ga28...@gmail.com> you wrote: > > > If you are not interested in such information, then just use > > appropriate log levels and filtering. > > I think the kernel log is the wrong place for this to go. Although, OK, this is your opinion, then, and I will

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Lee Jones
> > > I expolained it in my reply to your cover letter, i.e. in the message > > > immediately preceeding the one you replied to here. > > > > So you're telling me off for sending a patch which doesn't agree with > > something you've said, despite you saying it _after_ I sent the patch? > > > > S

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Wolfgang Denk
Dear Lee Jones, In message <20121121101310.gl28...@gmail.com> you wrote: > > > I expolained it in my reply to your cover letter, i.e. in the message > > immediately preceeding the one you replied to here. > > So you're telling me off for sending a patch which doesn't agree with > something you'v

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Lee Jones
> > > > This patch adds support for passing boot time information to > > > > the Linus kernel using ATAGS when booting on ARM based devices. > > > > > > I implicitly mentioned this before, here it comes clear again: > > > > Ah, this has been tried before? Sorry, I didn't know that. > > I expolai

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Wolfgang Denk
Dear Lee Jones, In message <20121121091717.gg28...@gmail.com> you wrote: > Hi Wolfgang, > > > In message <1353422034-28107-6-git-send-email-lee.jo...@linaro.org> you > > wrote: > > > This patch adds support for passing boot time information to > > > the Linus kernel using ATAGS when booting on A

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Lee Jones
Hi Wolfgang, > In message <1353422034-28107-6-git-send-email-lee.jo...@linaro.org> you wrote: > > This patch adds support for passing boot time information to > > the Linus kernel using ATAGS when booting on ARM based devices. > > I implicitly mentioned this before, here it comes clear again: Ah

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-20 Thread Wolfgang Denk
Dear Lee Jones, In message <1353422034-28107-6-git-send-email-lee.jo...@linaro.org> you wrote: > This patch adds support for passing boot time information to > the Linus kernel using ATAGS when booting on ARM based devices. I implicitly mentioned this before, here it comes clear again: I dislike

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-20 Thread Lee Jones
On Tue, 20 Nov 2012, Otavio Salvador wrote: > On Tue, Nov 20, 2012 at 12:33 PM, Lee Jones wrote: > > > This patch adds support for passing boot time information to > > the Linus kernel using ATAGS when booting on ARM based devices. > > Linus or Linux? Linux. I'll fix-up when the review proces

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-20 Thread Otavio Salvador
On Tue, Nov 20, 2012 at 12:33 PM, Lee Jones wrote: > This patch adds support for passing boot time information to > the Linus kernel using ATAGS when booting on ARM based devices. > Linus or Linux? > Based heavily on the original driver by Jonas Aaberg. > > Signed-off-by: Lee Jones > --- > a

[U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-20 Thread Lee Jones
This patch adds support for passing boot time information to the Linus kernel using ATAGS when booting on ARM based devices. Based heavily on the original driver by Jonas Aaberg. Signed-off-by: Lee Jones --- arch/arm/include/asm/setup.h | 18 + arch/arm/lib/bootm.c |