Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Stephen Warren
On 10/30/2012 06:44 AM, Lucas Stach wrote: > Hi Marek, > > Am Dienstag, den 30.10.2012, 13:33 +0100 schrieb Marek Vasut: >> Dear Lucas Stach, >> >> [...] >> > -static int add_port(struct fdt_usb *config) Fix the comment instead of removing it? >>> >>> I don't think that this comment

Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Simon Glass
Hi Lucas, On Tue, Oct 30, 2012 at 6:54 AM, Lucas Stach wrote: > Am Dienstag, den 30.10.2012, 06:48 -0700 schrieb Simon Glass: >> Hi Lucas, >> >> On Tue, Oct 30, 2012 at 6:37 AM, Lucas Stach wrote: >> > Am Dienstag, den 30.10.2012, 06:27 -0700 schrieb Simon Glass: >> >> Hi Lucas, >> >> >> >> On T

Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Lucas Stach
Am Dienstag, den 30.10.2012, 06:48 -0700 schrieb Simon Glass: > Hi Lucas, > > On Tue, Oct 30, 2012 at 6:37 AM, Lucas Stach wrote: > > Am Dienstag, den 30.10.2012, 06:27 -0700 schrieb Simon Glass: > >> Hi Lucas, > >> > >> On Tue, Oct 30, 2012 at 2:22 AM, Lucas Stach wrote: > >> > There is no need

Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Simon Glass
Hi Lucas, On Tue, Oct 30, 2012 at 6:37 AM, Lucas Stach wrote: > Am Dienstag, den 30.10.2012, 06:27 -0700 schrieb Simon Glass: >> Hi Lucas, >> >> On Tue, Oct 30, 2012 at 2:22 AM, Lucas Stach wrote: >> > There is no need to init a USB controller before the upper layers indicate >> > that they are

Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Lucas Stach
Am Dienstag, den 30.10.2012, 06:27 -0700 schrieb Simon Glass: > Hi Lucas, > > On Tue, Oct 30, 2012 at 2:22 AM, Lucas Stach wrote: > > There is no need to init a USB controller before the upper layers indicate > > that they are actually going to use it. > > > > board_usb_init now only parses the d

Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Simon Glass
Hi Lucas, On Tue, Oct 30, 2012 at 2:22 AM, Lucas Stach wrote: > There is no need to init a USB controller before the upper layers indicate > that they are actually going to use it. > > board_usb_init now only parses the device tree and sets up the common pll. > > Signed-off-by: Lucas Stach > ---

Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Lucas Stach
Hi Marek, Am Dienstag, den 30.10.2012, 13:33 +0100 schrieb Marek Vasut: > Dear Lucas Stach, > > [...] > > > > > -static int add_port(struct fdt_usb *config) > > > > > > Fix the comment instead of removing it? > > > > I don't think that this comment adds any real value. The whole function > > w

Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Marek Vasut
Dear Lucas Stach, [...] > > > -static int add_port(struct fdt_usb *config) > > > > Fix the comment instead of removing it? > > I don't think that this comment adds any real value. The whole function > which this comment refers to is removed and it's content split between > board_usb_init and eh

Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Lucas Stach
Hello Marek, Am Dienstag, den 30.10.2012, 11:59 +0100 schrieb Marek Vasut: > Dear Lucas Stach, > > > There is no need to init a USB controller before the upper layers indicate > > that they are actually going to use it. > > > > board_usb_init now only parses the device tree and sets up the commo

Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Marek Vasut
Dear Lucas Stach, > There is no need to init a USB controller before the upper layers indicate > that they are actually going to use it. > > board_usb_init now only parses the device tree and sets up the common pll. > > Signed-off-by: Lucas Stach > --- > arch/arm/cpu/armv7/tegra20/usb.c | 47 >

[U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

2012-10-30 Thread Lucas Stach
There is no need to init a USB controller before the upper layers indicate that they are actually going to use it. board_usb_init now only parses the device tree and sets up the common pll. Signed-off-by: Lucas Stach --- arch/arm/cpu/armv7/tegra20/usb.c | 47 +++-