Re: [U-Boot] [PATCH 7/8] powerpc/85xx: do not initialize QE if QE's firmware is in nand flash

2010-12-01 Thread Haiying Wang
On Wed, 2010-12-01 at 11:50 -0700, Kumar Gala wrote: > >> Any reason to just not move QE init for everyone? > >> > > That was based on Wolfgang's comment: > > http://lists.denx.de/pipermail/u-boot/2010-August/075657.html > > > > Haiying > > > > I think wolfgang's gripe is about putting the code in

Re: [U-Boot] [PATCH 7/8] powerpc/85xx: do not initialize QE if QE's firmware is in nand flash

2010-12-01 Thread Kumar Gala
On Dec 1, 2010, at 10:06 AM, Haiying Wang wrote: > On Wed, 2010-12-01 at 08:56 -0700, Kumar Gala wrote: >>> diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c >> b/arch/powerpc/cpu/mpc85xx/cpu_init.c >>> index 4b8faa5..eb34378 100644 >>> --- a/arch/powerpc/cpu/mpc85xx/cpu_init.c >>> +++ b/arch/powe

Re: [U-Boot] [PATCH 7/8] powerpc/85xx: do not initialize QE if QE's firmware is in nand flash

2010-12-01 Thread Haiying Wang
On Wed, 2010-12-01 at 08:56 -0700, Kumar Gala wrote: > > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c > b/arch/powerpc/cpu/mpc85xx/cpu_init.c > > index 4b8faa5..eb34378 100644 > > --- a/arch/powerpc/cpu/mpc85xx/cpu_init.c > > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init.c > > @@ -369,7 +369,7 @@ int

Re: [U-Boot] [PATCH 7/8] powerpc/85xx: do not initialize QE if QE's firmware is in nand flash

2010-12-01 Thread Kumar Gala
On Dec 1, 2010, at 9:50 AM, wrote: > From: Haiying Wang > > For some board which doesn't have NOR flash and the QE's firmware(ucode) is > saved in its NAND flash, we don't want call qe_init in cpu_init_r, but will > call it later after nand is initialized. > > Signed-off-by: Haiying Wang >

[U-Boot] [PATCH 7/8] powerpc/85xx: do not initialize QE if QE's firmware is in nand flash

2010-12-01 Thread Haiying.Wang
From: Haiying Wang For some board which doesn't have NOR flash and the QE's firmware(ucode) is saved in its NAND flash, we don't want call qe_init in cpu_init_r, but will call it later after nand is initialized. Signed-off-by: Haiying Wang --- arch/powerpc/cpu/mpc85xx/cpu_init.c |2 +- 1 f