Re: [U-Boot] [PATCH 7/9] net: rtl8169: Properly align buffers

2014-11-12 Thread Simon Glass
On 22 August 2014 03:15, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 01:29:57PM -0600, Stephen Warren wrote: On 08/18/2014 02:00 AM, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com RX and TX descriptor rings should be aligned to 256 byte boundaries.

Re: [U-Boot] [PATCH 7/9] net: rtl8169: Properly align buffers

2014-11-12 Thread Nobuhiro Iwamatsu
Hi! I comment to latest patch. Best regards, Nobuhiro 2014-11-13 1:23 GMT+09:00 Simon Glass s...@chromium.org: On 22 August 2014 03:15, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 01:29:57PM -0600, Stephen Warren wrote: On 08/18/2014 02:00 AM, Thierry Reding

Re: [U-Boot] [PATCH 7/9] net: rtl8169: Properly align buffers

2014-11-12 Thread Simon Glass
Hi Nobuhiro, On 12 November 2014 16:38, Nobuhiro Iwamatsu iwama...@nigauri.org wrote: Hi! I comment to latest patch. Best regards, Nobuhiro For me this one gives a warning, but I suppose the warning is correct. 2014-11-13 1:23 GMT+09:00 Simon Glass s...@chromium.org: On 22 August

Re: [U-Boot] [PATCH 7/9] net: rtl8169: Properly align buffers

2014-08-22 Thread Thierry Reding
On Wed, Aug 20, 2014 at 01:29:57PM -0600, Stephen Warren wrote: On 08/18/2014 02:00 AM, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com RX and TX descriptor rings should be aligned to 256 byte boundaries. Use the DEFINE_ALIGN_BUFFER() macro to define the buffers so that they

Re: [U-Boot] [PATCH 7/9] net: rtl8169: Properly align buffers

2014-08-20 Thread Stephen Warren
On 08/18/2014 02:00 AM, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com RX and TX descriptor rings should be aligned to 256 byte boundaries. Use the DEFINE_ALIGN_BUFFER() macro to define the buffers so that they don't have to be manually aligned later on. Also make sure that the

[U-Boot] [PATCH 7/9] net: rtl8169: Properly align buffers

2014-08-18 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com RX and TX descriptor rings should be aligned to 256 byte boundaries. Use the DEFINE_ALIGN_BUFFER() macro to define the buffers so that they don't have to be manually aligned later on. Also make sure that the buffers do align to cache-line boundaries in case