Re: [U-Boot] [PATCH 8/8] test/py: vboot: Remove stderr redirect from openssl command

2017-09-14 Thread Paul Burton
Hi Stephen, On Thursday, 14 September 2017 13:28:35 PDT Stephen Warren wrote: > I could have sworn I checked this code ran on Python 3 when I first > wrote it. Some of the issues you've fixed were clearly introduced since > then, but not all. Perhaps I'm remembering some other project where I >

Re: [U-Boot] [PATCH 8/8] test/py: vboot: Remove stderr redirect from openssl command

2017-09-14 Thread Stephen Warren
On 09/14/2017 02:06 PM, Paul Burton wrote: The openssl command specified in test_with_algo() ultimately ends up being run by RunAndLog::run(), which uses it to construct a Popen object with the default shell=False. The stderr redirect in the command is therefore simply passed to openssl as an

[U-Boot] [PATCH 8/8] test/py: vboot: Remove stderr redirect from openssl command

2017-09-14 Thread Paul Burton
The openssl command specified in test_with_algo() ultimately ends up being run by RunAndLog::run(), which uses it to construct a Popen object with the default shell=False. The stderr redirect in the command is therefore simply passed to openssl as an argument. With at least openssl 1.1.0f this