Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > I don't think this is as it should be. Any frame buffer that actually > > gets used as such should be located in the memory area specifically > > allocated for this purpose using lcd_setmem(). This is especially > > important when you load a splash scre

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Anatolij Gustschin
Hello Wolfgang, On Sun, 06 Jan 2013 21:21:00 +0100 Wolfgang Denk wrote: ... > > OK, so it is directly used as a frame buffer? In that case it looks > > right to me. I doubt you want to be able to control the cache features > > for this area, since you only write it once. But if you did, then the

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Anatolij Gustschin
Hi Simon, Lukasz, On Sun, 6 Jan 2013 07:47:58 -0800 Simon Glass wrote: ... > >> > diff --git a/common/cmd_bmp.c b/common/cmd_bmp.c > >> > index 5a52edd..57f3eb5 100644 > >> > --- a/common/cmd_bmp.c > >> > +++ b/common/cmd_bmp.c > >> > @@ -55,7 +55,7 @@ bmp_image_t *gunzip_bmp(unsigned long addr,

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Simon Glass
Hi Wolfgang, On Sun, Jan 6, 2013 at 12:21 PM, Wolfgang Denk wrote: > Dear Lukasz & Simon, > > In message > > Simon Glass wrote: >> >> >> > - dst = malloc(CONFIG_SYS_VIDEO_LOGO_MAX_SIZE); >> >> > + dst = memalign(CONFIG_SYS_CACHELINE_SIZE, len); >> >> >> >> Why do you need to align th

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Wolfgang Denk
Dear Lukasz & Simon, In message Simon Glass wrote: > > >> > - dst = malloc(CONFIG_SYS_VIDEO_LOGO_MAX_SIZE); > >> > + dst = memalign(CONFIG_SYS_CACHELINE_SIZE, len); > >> > >> Why do you need to align this one? It is just returned to the caller, > >> isn't it? > > > > Yes, it is retur

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Simon Glass
Hi Lukasz, On Sun, Jan 6, 2013 at 12:03 AM, Lukasz Majewski wrote: > Hi Simon, > >> Hi Lukasz, >> >> On Wed, Jan 2, 2013 at 8:25 AM, Lukasz Majewski >> wrote: >> > This commit makes the video subsystem code cache aware. >> > Memory allocated for decompressed BMP memory is now cache line >> > ali

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Lukasz Majewski
Hi Simon, > Hi Lukasz, > > On Wed, Jan 2, 2013 at 8:25 AM, Lukasz Majewski > wrote: > > This commit makes the video subsystem code cache aware. > > Memory allocated for decompressed BMP memory is now cache line > > aligned. > > > > Flushing of the dcache is also performed after copying BMP data

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-04 Thread Simon Glass
Hi Lukasz, On Wed, Jan 2, 2013 at 8:25 AM, Lukasz Majewski wrote: > This commit makes the video subsystem code cache aware. > Memory allocated for decompressed BMP memory is now cache line aligned. > > Flushing of the dcache is also performed after copying BMP data to fb > address (it is done for

[U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-02 Thread Lukasz Majewski
This commit makes the video subsystem code cache aware. Memory allocated for decompressed BMP memory is now cache line aligned. Flushing of the dcache is also performed after copying BMP data to fb address (it is done for 32 BPP bitmap used on Trats board (Exynos4210)). Tested-by: Lukasz Majewsk