[U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Stefano Babic
New default, weak i2c_set_bus_num() function. Signed-off-by: Stefano Babic Cc: Heiko Schocher --- Changes since V1: - add a weak function i2c_set_bus_num() to cmd_i2c.c instead of adding a dummy function to mxc_i2c.c. (Heiko Schocher) common/cmd_i2c.c |8 1 files changed, 8 inser

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Heiko Schocher
Hello Stefano, Stefano Babic wrote: > New default, weak i2c_set_bus_num() function. > > Signed-off-by: Stefano Babic > Cc: Heiko Schocher > --- > Changes since V1: > > - add a weak function i2c_set_bus_num() to cmd_i2c.c instead of adding a > dummy function to mxc_i2c.c. (Heiko Schocher) > >

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Tabi Timur-B04825
On Mon, Oct 10, 2011 at 4:35 AM, Stefano Babic wrote: > New default, weak i2c_set_bus_num() function. > > Signed-off-by: Stefano Babic > Cc: Heiko Schocher I would prefer to see a new set of I2C functions that take a bus number as a parameter, so that we can eliminate i2c_set_bus_num() (and the

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Mike Frysinger
On Monday 10 October 2011 13:53:48 Tabi Timur-B04825 wrote: > On Mon, Oct 10, 2011 at 4:35 AM, Stefano Babic wrote: > > New default, weak i2c_set_bus_num() function. > > > > Signed-off-by: Stefano Babic > > Cc: Heiko Schocher > > I would prefer to see a new set of I2C functions that take a bus

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Timur Tabi
Mike Frysinger wrote: > i think that'd require a much larger rework of the framework and thus would > be > better to do in addition to Stefano's work rather than in place of ? Hmmm... I guess it would be easier to do the rework eventually if i2c_set_bus_num() is universal, instead of just for Po

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Heiko Schocher
Hello Tabi, Tabi Timur-B04825 wrote: > On Mon, Oct 10, 2011 at 4:35 AM, Stefano Babic wrote: >> New default, weak i2c_set_bus_num() function. >> >> Signed-off-by: Stefano Babic >> Cc: Heiko Schocher > > I would prefer to see a new set of I2C functions that take a bus > number as a parameter, s

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Wolfgang Denk
Dear Heiko Schocher, In message <4e93d634.6080...@denx.de> you wrote: > > Then please have a look at: > > http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=shortlog;h=refs/heads/multibus_v2 > > It is a complete i2c rework with adding multiadapter/multibus > to the i2c framework (and a i2c_core.c) .

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Aaron Williams
On Monday, October 10, 2011 10:48:07 PM Wolfgang Denk wrote: > Dear Heiko Schocher, > > In message <4e93d634.6080...@denx.de> you wrote: > > Then please have a look at: > > > > http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=shortlog;h=refs/heads/multi > > bus_v2 > > > > It is a complete i2c rewor

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Heiko Schocher
Hello Wolfgang, Wolfgang Denk wrote: > Dear Heiko Schocher, > > In message <4e93d634.6080...@denx.de> you wrote: >> Then please have a look at: >> >> http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=shortlog;h=refs/heads/multibus_v2 >> >> It is a complete i2c rework with adding multiadapter/multibus

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-11 Thread Stefano Babic
On 10/10/2011 08:26 PM, Mike Frysinger wrote: > On Monday 10 October 2011 13:53:48 Tabi Timur-B04825 wrote: >> On Mon, Oct 10, 2011 at 4:35 AM, Stefano Babic wrote: >>> New default, weak i2c_set_bus_num() function. >>> >>> Signed-off-by: Stefano Babic >>> Cc: Heiko Schocher >> >> I would prefer