Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support

2010-07-08 Thread Prafulla Wadaskar
-Original Message- From: Albert ARIBAUD [mailto:albert.arib...@free.fr] Sent: Wednesday, July 07, 2010 7:39 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support Le 07/07/2010 13:46, Prafulla Wadaskar a écrit

Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support

2010-07-08 Thread Albert ARIBAUD
Le 08/07/2010 08:01, Prafulla Wadaskar a écrit : -Original Message- From: Albert ARIBAUD [mailto:albert.arib...@free.fr] Sent: Wednesday, July 07, 2010 7:39 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support Le 07/07

Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support

2010-07-07 Thread Prafulla Wadaskar
-Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Albert Aribaud Sent: Tuesday, July 06, 2010 9:29 PM To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH V2 3/3] edmini: add IDE support Signed-off-by: Albert Aribaud

Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support

2010-07-07 Thread Albert ARIBAUD
Le 07/07/2010 10:38, Prafulla Wadaskar a écrit : don't you think it is better to add separate driver for Orion/Kirkwood/Marvell SATAC so that this code and even some configurations can be shared by other boards. If you mean 'why use cmd_ide rather than the Marvell sata driver also posted

Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support

2010-07-07 Thread Prafulla Wadaskar
-Original Message- From: Albert ARIBAUD [mailto:albert.arib...@free.fr] Sent: Wednesday, July 07, 2010 4:20 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support Le 07/07/2010 10:38, Prafulla Wadaskar a écrit : don't

Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support

2010-07-07 Thread Albert ARIBAUD
Le 07/07/2010 13:46, Prafulla Wadaskar a écrit : If you mean 'why not make this a standalone driver, e.g. driver/net/mvsata_ide.{ch} under a configuration option CONFIG_MVSATA_IDE' -- why not, but it would basically be empty of 'driving' functionality (this is handled by cmd_ide) and would

[U-Boot] [PATCH V2 3/3] edmini: add IDE support

2010-07-06 Thread Albert Aribaud
Signed-off-by: Albert Aribaud albert.arib...@free.fr --- board/LaCie/edminiv2/edminiv2.c | 26 ++ include/configs/edminiv2.h | 29 +++-- 2 files changed, 53 insertions(+), 2 deletions(-) diff --git a/board/LaCie/edminiv2/edminiv2.c