Re: [U-Boot] [PATCH V3 1/5] i.mx: introduce the armv7/imx-common folder

2011-11-30 Thread Jason Hui
On Thu, Dec 1, 2011 at 8:04 AM, Fabio Estevam wrote: > On Fri, Nov 25, 2011 at 8:18 AM, Jason Liu wrote: > >> +static char *get_reset_cause(void) >> +{ >> +       u32 cause; >> +       struct src *src_regs = (struct src *)SRC_BASE_ADDR; >> + >> +       cause = readl(&src_regs->srsr); >> +       w

Re: [U-Boot] [PATCH V3 1/5] i.mx: introduce the armv7/imx-common folder

2011-11-30 Thread Fabio Estevam
On Fri, Nov 25, 2011 at 8:18 AM, Jason Liu wrote: > +static char *get_reset_cause(void) > +{ > +       u32 cause; > +       struct src *src_regs = (struct src *)SRC_BASE_ADDR; > + > +       cause = readl(&src_regs->srsr); > +       writel(cause, &src_regs->srsr); Isn´t this writel unneeded? Reg

[U-Boot] [PATCH V3 1/5] i.mx: introduce the armv7/imx-common folder

2011-11-25 Thread Jason Liu
In order to support the coming MX6 platform and to reducde the duplicated code, we had better move some common files or functions to the imx-common folder for sharing. This patch does the following: - move speed.c file from armv7/mx5/speed.c to armv7/imx-common/speed.c - move armv7/mx5/timer.c to