Re: [U-Boot] [PATCH V3 2/5] mv_i2c: use structure to replace the direclty define

2011-03-23 Thread Lei Wen
Hi Wolfgang, On Tue, Mar 22, 2011 at 11:16 PM, Wolfgang Denk w...@denx.de wrote: Dear Lei Wen, In message aanlktikmypvvjdrngrvz3xzsytn_yprpfmuup_3dd...@mail.gmail.com you wrote: ... -                     writel(readl(ICR) ~ICR_ACKNA K, ICR); -             writel(readl(ICR)

Re: [U-Boot] [PATCH V3 2/5] mv_i2c: use structure to replace the direclty define

2011-03-22 Thread Prafulla Wadaskar
-Original Message- From: Lei Wen [mailto:lei...@marvell.com] Sent: Thursday, March 17, 2011 12:15 PM To: Heiko Schocher; Wolfgang Denk; Prafulla Wadaskar; u- b...@lists.denx.de; Marek Vasut; Ashish Karkare; Prabhanjan Sarnaik; adrian.w...@gmail.com Subject: [PATCH V3 2/5] mv_i2c:

Re: [U-Boot] [PATCH V3 2/5] mv_i2c: use structure to replace the direclty define

2011-03-22 Thread Lei Wen
Hi Prafulla, On Tue, Mar 22, 2011 at 7:17 PM, Prafulla Wadaskar prafu...@marvell.com wrote: -Original Message- From: Lei Wen [mailto:lei...@marvell.com] Sent: Thursday, March 17, 2011 12:15 PM To: Heiko Schocher; Wolfgang Denk; Prafulla Wadaskar; u- b...@lists.denx.de; Marek Vasut;

Re: [U-Boot] [PATCH V3 2/5] mv_i2c: use structure to replace the direclty define

2011-03-22 Thread Wolfgang Denk
Dear Lei Wen, In message aanlktikmypvvjdrngrvz3xzsytn_yprpfmuup_3dd...@mail.gmail.com you wrote: ... - writel(readl(ICR) ~ICR_ACKNA K, ICR); - writel(readl(ICR) ~ICR_ALDIE, ICR); - writel(readl(ICR) | ICR_TB, ICR); +

[U-Boot] [PATCH V3 2/5] mv_i2c: use structure to replace the direclty define

2011-03-17 Thread Lei Wen
Signed-off-by: Lei Wen lei...@marvell.com --- Changelog: V3: clean code sytle issue arch/arm/cpu/pxa/cpu.c | 11 +++ arch/arm/include/asm/arch-pxa/pxa-regs.h | 56 - board/innokom/innokom.c |9 +-- drivers/i2c/mv_i2c.c |