Re: [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS

2012-01-27 Thread Eric Nelson
On 01/26/2012 07:50 PM, Mike Frysinger wrote: On Thursday 26 January 2012 20:22:22 Eric Nelson wrote: On 01/24/2012 11:08 AM, Mike Frysinger wrote: On Tuesday 24 January 2012 11:18:22 Eric Nelson wrote: This patch allows a board configuration file to provide a default chip-select for serial fl

Re: [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS

2012-01-26 Thread Mike Frysinger
On Thursday 26 January 2012 20:36:22 Eric Nelson wrote: > On 01/25/2012 08:10 AM, Matthias Fuchs wrote: > > On 24.01.2012 17:18, Eric Nelson wrote: > >> --- a/common/cmd_sf.c > >> +++ b/common/cmd_sf.c > >> > >>char *endp; > >>struct spi_flash *new; > >> > >> - if (argc< 2) > >> -

Re: [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS

2012-01-26 Thread Mike Frysinger
On Thursday 26 January 2012 20:22:22 Eric Nelson wrote: > On 01/24/2012 11:08 AM, Mike Frysinger wrote: > > On Tuesday 24 January 2012 11:18:22 Eric Nelson wrote: > >> This patch allows a board configuration file to provide a default > >> chip-select for serial flash so that first argument to the '

Re: [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS

2012-01-26 Thread Eric Nelson
On 01/25/2012 08:10 AM, Matthias Fuchs wrote: Hi Eric, please see my comments below. On 24.01.2012 17:18, Eric Nelson wrote: This patch allows a board configuration file to provide a default chip-select for serial flash so that first argument to the 'sf' command is optional. On boards that us

Re: [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS

2012-01-26 Thread Eric Nelson
On 01/24/2012 11:08 AM, Mike Frysinger wrote: On Tuesday 24 January 2012 11:18:22 Eric Nelson wrote: This patch allows a board configuration file to provide a default chip-select for serial flash so that first argument to the 'sf' command is optional. On boards that use the mxc_spi driver and a

Re: [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS

2012-01-25 Thread Mike Frysinger
On Wednesday 25 January 2012 10:10:18 Matthias Fuchs wrote: > Can you also add a config option for the SPI bus number? I think these > two need to handled in the same patch. > > So you could add this stuff: > > static int do_spi_flash_probe(int argc, char * const argv[]) > { > +#ifdef CONFIG_SF

Re: [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS

2012-01-25 Thread Matthias Fuchs
Hi Eric, please see my comments below. On 24.01.2012 17:18, Eric Nelson wrote: > This patch allows a board configuration file to provide a default > chip-select for serial flash so that first argument to the 'sf' command > is optional. > > On boards that use the mxc_spi driver and a GPIO for ch

Re: [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS

2012-01-24 Thread Mike Frysinger
On Tuesday 24 January 2012 11:18:22 Eric Nelson wrote: > This patch allows a board configuration file to provide a default > chip-select for serial flash so that first argument to the 'sf' command > is optional. > > On boards that use the mxc_spi driver and a GPIO for chip select, this > allows a

Re: [U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS

2012-01-24 Thread Fabio Estevam
On 1/24/12, Eric Nelson wrote: > This patch allows a board configuration file to provide a default > chip-select for serial flash so that first argument to the 'sf' command > is optional. > > On boards that use the mxc_spi driver and a GPIO for chip select, this > allows > a much simpler command l

[U-Boot] [PATCH V3 4/6] sf command: allow default chip select through CONFIG_SPI_FLASH_CS

2012-01-24 Thread Eric Nelson
This patch allows a board configuration file to provide a default chip-select for serial flash so that first argument to the 'sf' command is optional. On boards that use the mxc_spi driver and a GPIO for chip select, this allows a much simpler command line: U-Boot> sf probe instead of