Re: [U-Boot] [PATCH V4] arm: Tegra2: add support for A9 CPU init

2011-04-13 Thread Albert ARIBAUD
Le 12/04/2011 23:02, Tom Warren a écrit : diff --git a/arch/arm/cpu/armv7/tegra2/ap20.c b/arch/arm/cpu/armv7/tegra2/ap20.c new file mode 100644 index 000..075341e --- /dev/null +++ b/arch/arm/cpu/armv7/tegra2/ap20.c @@ -0,0 +1,325 @@ +/* +* (C) Copyright 2010-2011 +* NVIDIA

Re: [U-Boot] [PATCH V4] arm: Tegra2: add support for A9 CPU init

2011-04-13 Thread Tom Warren
Albert, On Wed, Apr 13, 2011 at 1:09 PM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Le 12/04/2011 23:02, Tom Warren a écrit : diff --git a/arch/arm/cpu/armv7/tegra2/ap20.c b/arch/arm/cpu/armv7/tegra2/ap20.c new file mode 100644 index 000..075341e --- /dev/null +++

Re: [U-Boot] [PATCH V4] arm: Tegra2: add support for A9 CPU init

2011-04-13 Thread Albert ARIBAUD
Hi Tom, Le 13/04/2011 22:21, Tom Warren a écrit : + + /* Wait for the power to come up */ + while (!is_cpu_powered()) + ; /* Do nothing */ What if power never comes up? Then the system is hung. I can put a printf

Re: [U-Boot] [PATCH V4] arm: Tegra2: add support for A9 CPU init

2011-04-13 Thread Tom Warren
Albert, On Wed, Apr 13, 2011 at 1:30 PM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hi Tom, Le 13/04/2011 22:21, Tom Warren a écrit : + +               /* Wait for the power to come up */ +               while (!is_cpu_powered()) +                       ;                       /* Do

[U-Boot] [PATCH V4] arm: Tegra2: add support for A9 CPU init

2011-04-12 Thread Tom Warren
Signed-off-by: Tom Warren twar...@nvidia.com --- Changes for V2: - Remove returns in void functions - Move inline assembly code to .S file - Simplify some if/else code, break out common code - Minimize the use of local vars - Inline some single-instance