Re: [U-Boot] [PATCH V4 5/6] exynos: Add a common DT based PMIC driver initialization

2014-01-15 Thread Leela Krishna Amudala
Hi, On 1/16/14, Minkyu Kang wrote: > On 16/01/14 13:05, Leela Krishna Amudala wrote: >> Hi Minkyu Kang, >> >> Thanks for reviewing the patch, Please check my comments inline. >> >> On 1/7/14, Minkyu Kang wrote: >>> On 06/01/14 20:49, Leela Krishna Amudala wrote: Most of i2c PMIC drivers fol

Re: [U-Boot] [PATCH V4 5/6] exynos: Add a common DT based PMIC driver initialization

2014-01-15 Thread Minkyu Kang
On 16/01/14 13:05, Leela Krishna Amudala wrote: > Hi Minkyu Kang, > > Thanks for reviewing the patch, Please check my comments inline. > > On 1/7/14, Minkyu Kang wrote: >> On 06/01/14 20:49, Leela Krishna Amudala wrote: >>> Most of i2c PMIC drivers follow the same initialization sequence, >>> le

Re: [U-Boot] [PATCH V4 5/6] exynos: Add a common DT based PMIC driver initialization

2014-01-15 Thread Leela Krishna Amudala
Hi Minkyu Kang, Thanks for reviewing the patch, Please check my comments inline. On 1/7/14, Minkyu Kang wrote: > On 06/01/14 20:49, Leela Krishna Amudala wrote: >> Most of i2c PMIC drivers follow the same initialization sequence, >> let's generalize it in a common file. >> >> The initialization

Re: [U-Boot] [PATCH V4 5/6] exynos: Add a common DT based PMIC driver initialization

2014-01-07 Thread Minkyu Kang
On 06/01/14 20:49, Leela Krishna Amudala wrote: > Most of i2c PMIC drivers follow the same initialization sequence, > let's generalize it in a common file. > > The initialization function finds the PMIC in the device tree, and if > found - registers it in the list of known PMICs and initializes it

[U-Boot] [PATCH V4 5/6] exynos: Add a common DT based PMIC driver initialization

2014-01-06 Thread Leela Krishna Amudala
Most of i2c PMIC drivers follow the same initialization sequence, let's generalize it in a common file. The initialization function finds the PMIC in the device tree, and if found - registers it in the list of known PMICs and initializes it, iterating through the table of settings supplied by the