[U-Boot] [PATCH v0 1/5] pci: mvebu: Fix Armada 38x support

2015-10-28 Thread dirk . eibach
From: Dirk Eibach Armada 38x has 4 pci ports, not 3. The optimization in pci_init_board() seems to assume, that every port has 3 lanes. This is obviously wrong and breaks support for Armada 38x. Signed-off-by: Dirk Eibach --- arch/arm/mach-mvebu/include/mach/soc.h | 1 + drivers/pci/pci_mveb

Re: [U-Boot] [PATCH v0 1/5] pci: mvebu: Fix Armada 38x support

2015-10-28 Thread Stefan Roese
Hi Dirk, On 28.10.2015 16:44, dirk.eib...@gdsys.cc wrote: From: Dirk Eibach Armada 38x has 4 pci ports, not 3. The optimization in pci_init_board() seems to assume, that every port has 3 lanes. This is obviously wrong and breaks support for Armada 38x. Signed-off-by: Dirk Eibach Looks good

Re: [U-Boot] [PATCH v0 1/5] pci: mvebu: Fix Armada 38x support

2015-11-17 Thread Anton Schubert
Hi Dirk, 2015-10-28 16:44 GMT+01:00 : > From: Dirk Eibach > > @@ -344,7 +345,6 @@ void pci_init_board(void) > > /* Don't read at all from pci registers if port power is > down */ > if (pcie->lane == 0 && SELECT(soc_ctrl, pcie->port) == 0) { > -

Re: [U-Boot] [PATCH v0 1/5] pci: mvebu: Fix Armada 38x support

2015-11-18 Thread Dirk Eibach
Hi Anton, 2015-11-17 13:55 GMT+01:00 Anton Schubert : > Hi Dirk, > > 2015-10-28 16:44 GMT+01:00 : >> >> From: Dirk Eibach >> >> @@ -344,7 +345,6 @@ void pci_init_board(void) >> >> /* Don't read at all from pci registers if port power is >> down */ >> if (pcie->lane

Re: [U-Boot] [PATCH v0 1/5] pci: mvebu: Fix Armada 38x support

2015-11-18 Thread Anton Schubert
Am 18.11.2015 um 13:48 schrieb Dirk Eibach: > I assume the idea is to go to the next port if the current port is > disabled. But adding 3 to the index does not seem to be the right > thing to do, since Armada XP has ports with 4 lanes, but also with > ports with one lane. > I assume that iterating

Re: [U-Boot] [PATCH v0 1/5] pci: mvebu: Fix Armada 38x support

2015-11-18 Thread Dirk Eibach
2015-11-18 14:23 GMT+01:00 Anton Schubert : > Am 18.11.2015 um 13:48 schrieb Dirk Eibach: >> I assume the idea is to go to the next port if the current port is >> disabled. But adding 3 to the index does not seem to be the right >> thing to do, since Armada XP has ports with 4 lanes, but also with