Re: [U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

Hi Jagan, > On Tue, Jan 29, 2019 at 1:35 PM Lukasz Majewski wrote: > > > > Hi Jagan, > > > > > On Tue, Jan 29, 2019 at 12:46 PM Lukasz Majewski > > > wrote: > > > > > > > > Hi Stefano, Fabio, > > > > > > > > > Hi Lukasz, > > > > > > > > > > On 21/01/19 15:19, Lukasz Majewski wrote: > > >

Re: [U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

On Tue, Jan 29, 2019 at 1:35 PM Lukasz Majewski wrote: > > Hi Jagan, > > > On Tue, Jan 29, 2019 at 12:46 PM Lukasz Majewski > > wrote: > > > > > > Hi Stefano, Fabio, > > > > > > > Hi Lukasz, > > > > > > > > On 21/01/19 15:19, Lukasz Majewski wrote: > > > > > Hi Fabio, > > > > > > > > > >> Hi Luka

Re: [U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

Hi Jagan, > On Tue, Jan 29, 2019 at 12:46 PM Lukasz Majewski > wrote: > > > > Hi Stefano, Fabio, > > > > > Hi Lukasz, > > > > > > On 21/01/19 15:19, Lukasz Majewski wrote: > > > > Hi Fabio, > > > > > > > >> Hi Lukasz, > > > >> > > > >> On Sat, Jan 19, 2019 at 7:15 AM Lukasz Majewski > > >

Re: [U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

On Tue, Jan 29, 2019 at 12:46 PM Lukasz Majewski wrote: > > Hi Stefano, Fabio, > > > Hi Lukasz, > > > > On 21/01/19 15:19, Lukasz Majewski wrote: > > > Hi Fabio, > > > > > >> Hi Lukasz, > > >> > > >> On Sat, Jan 19, 2019 at 7:15 AM Lukasz Majewski > > >> wrote: > > >>> +static ulong imx6q_clk_get

Re: [U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

Hi Stefano, Fabio, > Hi Lukasz, > > On 21/01/19 15:19, Lukasz Majewski wrote: > > Hi Fabio, > > > >> Hi Lukasz, > >> > >> On Sat, Jan 19, 2019 at 7:15 AM Lukasz Majewski > >> wrote: > >>> +static ulong imx6q_clk_get_rate(struct clk *clk) > >>> +{ > >>> + ulong rate = 0; > >>> + > >>> +

Re: [U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

Hi Lukasz, On 21/01/19 15:19, Lukasz Majewski wrote: > Hi Fabio, > >> Hi Lukasz, >> >> On Sat, Jan 19, 2019 at 7:15 AM Lukasz Majewski wrote: >> >>> +static ulong imx6q_clk_get_rate(struct clk *clk) >>> +{ >>> + ulong rate = 0; >>> + >>> + debug("%s(#%lu)\n", __func__, clk->id); >>>

Re: [U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

Hi Lukasz, On Mon, Jan 21, 2019 at 12:19 PM Lukasz Majewski wrote: > The rationale regarding this approach: > > 1. Reuse the clock.c code for iMX6Q as much as possible. Yes, the problem is that clock.c does not scale well as we have dedicated clock functions for each peripheral: enable_uart_clk

Re: [U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

Hi Fabio, > Hi Lukasz, > > On Sat, Jan 19, 2019 at 7:15 AM Lukasz Majewski wrote: > > > +static ulong imx6q_clk_get_rate(struct clk *clk) > > +{ > > + ulong rate = 0; > > + > > + debug("%s(#%lu)\n", __func__, clk->id); > > + > > + switch (clk->id) { > > + case IMX6QDL_CL

Re: [U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

Hi Lukasz, On Sat, Jan 19, 2019 at 7:15 AM Lukasz Majewski wrote: > +static ulong imx6q_clk_get_rate(struct clk *clk) > +{ > + ulong rate = 0; > + > + debug("%s(#%lu)\n", __func__, clk->id); > + > + switch (clk->id) { > + case IMX6QDL_CLK_ECSPI1: > + case IMX6QDL_CL

[U-Boot] [PATCH v1 06/15] dm: clk: imx: Add support for controlling imx6q clocks via Driver Model

This commit provides support for setting USDHCx/ECSPIx clocks depending on used bus. Moreover, it is agnostic to the alias numbering as the information about the clock is read from device tree. Last but not least - the current IMX6Q clock code in mach-imx/mx6/clock.c has been reused to avoid code