Re: [U-Boot] [PATCH v1 8/8] OMAP3: mt_ventoux: added video support

2012-08-28 Thread Stefano Babic
On 28/08/2012 10:47, Jeroen Hofstee wrote: > Hello Stefano, > > Could we use here a define, something like this: > > #define PANEL_TIMING_H(bp, fp, sw) (((bp - 1) << 20) | ((fp - 1) << 8) | > (sw - 1)) > >> Agree - and put it in a common header (arch/dss.h), making it accessible >> to all boards

Re: [U-Boot] [PATCH v1 8/8] OMAP3: mt_ventoux: added video support

2012-08-28 Thread Jeroen Hofstee
Hello Stefano, Could we use here a define, something like this: #define PANEL_TIMING_H(bp, fp, sw) (((bp - 1) << 20) | ((fp - 1) << 8) | (sw - 1)) Agree - and put it in a common header (arch/dss.h), making it accessible to all boards. And we need only one macro PANEL_TIMING, the register has t

Re: [U-Boot] [PATCH v1 8/8] OMAP3: mt_ventoux: added video support

2012-08-28 Thread Stefano Babic
On 28/08/2012 10:11, Heiko Schocher wrote: > Hello Stefano, > Hi Heiko, >> +static struct panel_config lcd_cfg[] = { >> +{ >> +.timing_h = ((4 /* hpb */ - 1)<< 20) | >> +((8 /*hfp */- 1)<< 8) | >> +(41 /* hsw */ - 1), /* Horizontal timing */ > > Could we

Re: [U-Boot] [PATCH v1 8/8] OMAP3: mt_ventoux: added video support

2012-08-28 Thread Heiko Schocher
Hello Stefano, On 28.08.2012 09:46, Stefano Babic wrote: Signed-off-by: Stefano Babic --- board/teejet/mt_ventoux/mt_ventoux.c | 91 ++ board/teejet/mt_ventoux/mt_ventoux.h |2 +- include/configs/mt_ventoux.h | 16 ++ 3 files changed, 108

[U-Boot] [PATCH v1 8/8] OMAP3: mt_ventoux: added video support

2012-08-28 Thread Stefano Babic
Signed-off-by: Stefano Babic --- board/teejet/mt_ventoux/mt_ventoux.c | 91 ++ board/teejet/mt_ventoux/mt_ventoux.h |2 +- include/configs/mt_ventoux.h | 16 ++ 3 files changed, 108 insertions(+), 1 deletion(-) diff --git a/board/teejet/mt_vent