[U-Boot] [PATCH v2] add dm9000 eeprom read/write command

2011-08-28 Thread Eric Jarrige
Signed-off-by: Eric Jarrige Signed-off-by: Stefano Babic Cc: Wolfgang Denk Cc: Detlev Zundel Changes for v2: - remove DM9000 driver dependant compilation flag --- README|1 + common/Makefile |1 + common/cmd_dm9000ee.c | 82 +

Re: [U-Boot] [PATCH v2] add dm9000 eeprom read/write command

2011-08-30 Thread Stefano Babic
On 08/28/2011 11:47 PM, Eric Jarrige wrote: > Signed-off-by: Eric Jarrige > Signed-off-by: Stefano Babic > Cc: Wolfgang Denk > Cc: Detlev Zundel > > Changes for v2: > - remove DM9000 driver dependant compilation flag > --- Hi Eric, why should this code put in a separate file and not in

Re: [U-Boot] [PATCH v2] add dm9000 eeprom read/write command

2011-08-30 Thread Eric Jarrige
Hi Stefano, On 30 août 2011, at 11:47, Stefano Babic wrote: > On 08/28/2011 11:47 PM, Eric Jarrige wrote: >> Signed-off-by: Eric Jarrige >> Signed-off-by: Stefano Babic >> Cc: Wolfgang Denk >> Cc: Detlev Zundel >> >> Changes for v2: >> - remove DM9000 driver dependant compilation flag >

Re: [U-Boot] [PATCH v2] add dm9000 eeprom read/write command

2011-08-31 Thread Stefano Babic
On 08/30/2011 11:17 PM, Eric Jarrige wrote: > Hi Stefano, Hi Eric, > Sorry for the confusion, I did not understood that your remark was > not related to the compilation flags. > Now, I've checked how to have this U-Boot commands in the driver > itself. I think it's doable if I can have a compila

Re: [U-Boot] [PATCH v2] add dm9000 eeprom read/write command

2011-08-31 Thread Eric Jarrige
On 31 août 2011, at 15:01, Stefano Babic wrote: > Hi Eric, > >> Sorry for the confusion, I did not understood that your remark was >> not related to the compilation flags. >> Now, I've checked how to have this U-Boot commands in the driver >> itself. I think it's doable if I can have a compilati

Re: [U-Boot] [PATCH v2] add dm9000 eeprom read/write command

2011-09-01 Thread Stefano Babic
On 09/01/2011 12:27 AM, Eric Jarrige wrote: > > On 31 août 2011, at 15:01, Stefano Babic wrote: >> You could add a CONFIG_DM9000_* switch. This set a switch only for the >> DM9000 driver and the name remembers that it is used only inside the >> driver itself, such as CONFIG_DM9000_DEBUG and CONFIG