Re: [U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-11-23 Thread Simon Goldschmidt
On 23.11.2018 14:12, Jagan Teki wrote: On Fri, Nov 23, 2018 at 6:24 PM Simon Goldschmidt wrote: [Responding from my work address due to problems with gmail] On 23.11.2018 13:27, Jagan Teki wrote: On Fri, Nov 23, 2018 at 1:51 AM wrote: On Fri, 16 Nov 2018 at 12:40, Simon Goldschmidt wro

Re: [U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-11-23 Thread Jagan Teki
On Fri, Nov 23, 2018 at 6:24 PM Simon Goldschmidt wrote: > > [Responding from my work address due to problems with gmail] > > On 23.11.2018 13:27, Jagan Teki wrote: > > On Fri, Nov 23, 2018 at 1:51 AM wrote: > >> > >> On Fri, 16 Nov 2018 at 12:40, Simon Goldschmidt > >> wrote: > >>> > >>> On 31.

Re: [U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-11-23 Thread Simon Goldschmidt
[Responding from my work address due to problems with gmail] On 23.11.2018 13:27, Jagan Teki wrote: On Fri, Nov 23, 2018 at 1:51 AM wrote: On Fri, 16 Nov 2018 at 12:40, Simon Goldschmidt wrote: On 31.10.2018 07:42, Simon Goldschmidt wrote: On Wed, Oct 31, 2018 at 7:22 AM Jagan Teki wrote

Re: [U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-11-23 Thread Jagan Teki
On Fri, Nov 23, 2018 at 1:51 AM wrote: > > On Fri, 16 Nov 2018 at 12:40, Simon Goldschmidt > wrote: > > > > On 31.10.2018 07:42, Simon Goldschmidt wrote: > > > On Wed, Oct 31, 2018 at 7:22 AM Jagan Teki > > > wrote: > > >> On Wed, Oct 31, 2018 at 1:40 AM Simon Goldschmidt > > >> wrote: > > >>>

Re: [U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-11-22 Thread sjg
On Fri, 16 Nov 2018 at 12:40, Simon Goldschmidt wrote: > > On 31.10.2018 07:42, Simon Goldschmidt wrote: > > On Wed, Oct 31, 2018 at 7:22 AM Jagan Teki > > wrote: > >> On Wed, Oct 31, 2018 at 1:40 AM Simon Goldschmidt > >> wrote: > >>> When the device tree is missing a correct spi slave descrip

Re: [U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-11-16 Thread Simon Glass
On Fri, 16 Nov 2018 at 12:40, Simon Goldschmidt wrote: > > On 31.10.2018 07:42, Simon Goldschmidt wrote: > > On Wed, Oct 31, 2018 at 7:22 AM Jagan Teki > > wrote: > >> On Wed, Oct 31, 2018 at 1:40 AM Simon Goldschmidt > >> wrote: > >>> When the device tree is missing a correct spi slave descrip

Re: [U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-11-16 Thread Simon Goldschmidt
On 31.10.2018 07:42, Simon Goldschmidt wrote: On Wed, Oct 31, 2018 at 7:22 AM Jagan Teki wrote: On Wed, Oct 31, 2018 at 1:40 AM Simon Goldschmidt wrote: When the device tree is missing a correct spi slave description below the bus (compatible "spi-flash" or spi-max-frequency are missing), the

Re: [U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-10-30 Thread Simon Goldschmidt
On Wed, Oct 31, 2018 at 7:22 AM Jagan Teki wrote: > > On Wed, Oct 31, 2018 at 1:40 AM Simon Goldschmidt > wrote: > > > > When the device tree is missing a correct spi slave description below > > the bus (compatible "spi-flash" or spi-max-frequency are missing), > > the 'set_speed' callback can be

Re: [U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-10-30 Thread Jagan Teki
On Wed, Oct 31, 2018 at 1:40 AM Simon Goldschmidt wrote: > > When the device tree is missing a correct spi slave description below > the bus (compatible "spi-flash" or spi-max-frequency are missing), > the 'set_speed' callback can be called with 'speed' == 0 Hz. > At least with cadence qspi, this

[U-Boot] [PATCH v2] dm: spi: prevent setting a speed of 0 Hz

2018-10-30 Thread Simon Goldschmidt
When the device tree is missing a correct spi slave description below the bus (compatible "spi-flash" or spi-max-frequency are missing), the 'set_speed' callback can be called with 'speed' == 0 Hz. At least with cadence qspi, this leads to a division by zero. Prevent this by initializing speed to