Re: [U-Boot] [PATCH v2] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-20 Thread Stefan Roese
Hi Dirk, On Wednesday 19 October 2011 16:36:08 Mike Frysinger wrote: the GPIO API is not specific to processors. atm, only SoC's are implementing it. what you're looking for is the gpiolib which Linux supports. we haven't bothered adding that layer yet as no one was adding GPIO expanders.

[U-Boot] [PATCH v2] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-19 Thread Dirk Eibach
Signed-off-by: Dirk Eibach eib...@gdsys.de --- Changes for v2: - fixed parameters for memset() in pca9698_set_output() drivers/gpio/Makefile |1 + drivers/gpio/pca9698.c | 123 include/pca9698.h |9 3 files changed, 133

Re: [U-Boot] [PATCH v2] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-19 Thread Stefan Roese
Hi Dirk, On Wednesday 19 October 2011 08:34:00 Dirk Eibach wrote: Signed-off-by: Dirk Eibach eib...@gdsys.de --- Changes for v2: - fixed parameters for memset() in pca9698_set_output() Thanks. While looking again, I noticed that you are not using the standard GPIO API borrowed from

Re: [U-Boot] [PATCH v2] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-19 Thread Eibach, Dirk
Hi Stefan. While looking again, I noticed that you are not using the standard GPIO API borrowed from Linux. Please take a look at drivers/gpio/mxc_gpio.c or drivers/gpio/mvgpio.c as an example. Sorry for not mentioning this earlier. Could you please update this patch and your Io64 BSP

Re: [U-Boot] [PATCH v2] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-19 Thread Mike Frysinger
On Wednesday 19 October 2011 04:37:26 Eibach, Dirk wrote: While looking again, I noticed that you are not using the standard GPIO API borrowed from Linux. Please take a look at drivers/gpio/mxc_gpio.c or drivers/gpio/mvgpio.c as an example. Sorry for not mentioning this earlier. Could

Re: [U-Boot] [PATCH v2] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-19 Thread Mike Frysinger
On Wednesday 19 October 2011 02:34:00 Dirk Eibach wrote: --- /dev/null +++ b/include/pca9698.h +#ifndef __PCA9698_H_ +#define __PCA9698_H_ missing copyright/license/etc... comment block at top of file +int pca9698_direction_input(u8 chip, unsigned offset); +int pca9698_direction_output(u8