Re: [U-Boot] [PATCH v2] image: Fix Android boot image support

2014-10-23 Thread Ahmad Draidi
Hello, Mr. Glass. On Wednesday 22 October 2014 11:29:00 AM Simon Glass wrote: One little nit below but it looks OK to me. I'm assume that no one would want to replace the command line completely? In some setups, one image can be used with several versions, or even different boards of

Re: [U-Boot] [PATCH v2] image: Fix Android boot image support

2014-10-23 Thread Simon Glass
Hi Ahmad, On 23 October 2014 00:08, Ahmad Draidi ar200...@gmail.com wrote: Hello, Mr. Glass. On Wednesday 22 October 2014 11:29:00 AM Simon Glass wrote: One little nit below but it looks OK to me. I'm assume that no one would want to replace the command line completely? In some setups,

Re: [U-Boot] [PATCH v2] image: Fix Android boot image support

2014-10-22 Thread Simon Glass
Hi Ahmad, On 21 October 2014 10:55, Ahmad Draidi ar200...@gmail.com wrote: This patch makes the following changes: - Set kernel entry point correctly - Append bootargs from image to global bootargs instead of replacing them - Return end address instead of size from

[U-Boot] [PATCH v2] image: Fix Android boot image support

2014-10-21 Thread Ahmad Draidi
This patch makes the following changes: - Set kernel entry point correctly - Append bootargs from image to global bootargs instead of replacing them - Return end address instead of size from android_image_get_end() - Give correct parameter to genimg_get_format() in boot_get_ramdisk()