Re: [U-Boot] [PATCH v2] mvgbe: remove setting of ethaddr within the driver

2011-12-20 Thread Wolfgang Denk
Dear Michael Walle, In message 1321570349-4224-1-git-send-email-mich...@walle.cc you wrote: A network driver should not touch the environment at all. This patch fixes this behaviour by removing the code for setting a default/randomized MAC address. Signed-off-by: Michael Walle

Re: [U-Boot] [PATCH v2] mvgbe: remove setting of ethaddr within the driver

2011-12-20 Thread Wolfgang Denk
Dear Michael Walle, In message 1321570349-4224-1-git-send-email-mich...@walle.cc you wrote: A network driver should not touch the environment at all. This patch fixes this behaviour by removing the code for setting a default/randomized MAC address. Signed-off-by: Michael Walle

Re: [U-Boot] [PATCH v2] mvgbe: remove setting of ethaddr within the driver

2011-11-20 Thread Prafulla Wadaskar
-Original Message- From: Michael Walle [mailto:mich...@walle.cc] Sent: Friday, November 18, 2011 4:22 AM To: u-boot@lists.denx.de Cc: Wolfgang Denk; Michael Walle; Mike Frysinger; Prafulla Wadaskar; Valentin Longchamp; Eric Cooper; Jason Cooper; Siddarth Gore; Albert ARIBAUD;

Re: [U-Boot] [PATCH v2] mvgbe: remove setting of ethaddr within the driver

2011-11-18 Thread Mike Frysinger
On Thursday 17 November 2011 17:52:29 Michael Walle wrote: --- a/drivers/net/mvgbe.c +++ b/drivers/net/mvgbe.c switch (devnum) { case 0: dmvgbe-regs = (void *)MVGBE0_BASE; unrelated, but usually this is pushed into an option to the init func

[U-Boot] [PATCH v2] mvgbe: remove setting of ethaddr within the driver

2011-11-17 Thread Michael Walle
A network driver should not touch the environment at all. This patch fixes this behaviour by removing the code for setting a default/randomized MAC address. Signed-off-by: Michael Walle mich...@walle.cc Acked-by: Mike Frysinger vap...@gentoo.org Acked-by: Prafulla Wadaskar prafu...@marvell.com