Re: [U-Boot] [PATCH v2] tools/env: fix environment alignment tests for block devices

2016-11-28 Thread Max Krummenacher
Hi Andreas 2016-11-28 10:47 GMT+01:00 Andreas Fenkart : > Hi Max, > > LGTM, see one nit below, can fixed later > > > On 11/19/2016 01:58 PM, Max Krummenacher wrote: >> >> commit 183923d3e412500bdc597d1745e2fb6f7f679ec7 enforces that the >> environment must start at an erase block boundary. >> >> F

Re: [U-Boot] [PATCH v2] tools/env: fix environment alignment tests for block devices

2016-11-28 Thread Andreas Fenkart
Hi Max, LGTM, see one nit below, can fixed later On 11/19/2016 01:58 PM, Max Krummenacher wrote: commit 183923d3e412500bdc597d1745e2fb6f7f679ec7 enforces that the environment must start at an erase block boundary. For block devices the sample fw_env.config does not mandate a erase block size f

Re: [U-Boot] [PATCH v2] tools/env: fix environment alignment tests for block devices

2016-11-28 Thread Max Krummenacher
Hi Any news on this? The env utility is currently broken for block devices. Alternatively we could also revert commit 183923d3e412500bdc597d1745e2fb6f7f679ec7. Regards Max ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinf

[U-Boot] [PATCH v2] tools/env: fix environment alignment tests for block devices

2016-11-19 Thread Max Krummenacher
commit 183923d3e412500bdc597d1745e2fb6f7f679ec7 enforces that the environment must start at an erase block boundary. For block devices the sample fw_env.config does not mandate a erase block size for block devices. A missing setting defaults to the full env size. Depending on the environment loca