Re: [U-Boot] [PATCH v2 01/23] log: Correct definition of log_msg_ret()

2018-11-15 Thread Simon Glass
Hi Bin, On 15 November 2018 at 17:43, Bin Meng wrote: > > Hi Simon, > > On Fri, Nov 16, 2018 at 8:08 AM Simon Glass wrote: > > > > Hi Bin, > > > > On 4 October 2018 at 02:25, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Tue, Oct 2, 2018 at 8:25 PM Simon Glass wrote: > > > > > > > >

Re: [U-Boot] [PATCH v2 01/23] log: Correct definition of log_msg_ret()

2018-11-15 Thread Bin Meng
Hi Simon, On Fri, Nov 16, 2018 at 8:08 AM Simon Glass wrote: > > Hi Bin, > > On 4 October 2018 at 02:25, Bin Meng wrote: > > > > Hi Simon, > > > > On Tue, Oct 2, 2018 at 8:25 PM Simon Glass wrote: > > > > > > This macro should have two parameters, not one. Fix it so that it > > > correctly

Re: [U-Boot] [PATCH v2 01/23] log: Correct definition of log_msg_ret()

2018-11-15 Thread Simon Glass
Hi Bin, On 4 October 2018 at 02:25, Bin Meng wrote: > > Hi Simon, > > On Tue, Oct 2, 2018 at 8:25 PM Simon Glass wrote: > > > > This macro should have two parameters, not one. Fix it so that it > > correctly resolves to _ret when logging is disabled. > > > > Signed-off-by: Simon Glass > > ---

Re: [U-Boot] [PATCH v2 01/23] log: Correct definition of log_msg_ret()

2018-10-04 Thread Bin Meng
Hi Simon, On Tue, Oct 2, 2018 at 8:25 PM Simon Glass wrote: > > This macro should have two parameters, not one. Fix it so that it > correctly resolves to _ret when logging is disabled. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > include/log.h | 2 +- > 1 file changed, 1

[U-Boot] [PATCH v2 01/23] log: Correct definition of log_msg_ret()

2018-10-02 Thread Simon Glass
This macro should have two parameters, not one. Fix it so that it correctly resolves to _ret when logging is disabled. Signed-off-by: Simon Glass --- Changes in v2: None include/log.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/log.h b/include/log.h index