Re: [U-Boot] [PATCH v2 02/22] omap4: add OMAP4430 revision check

2011-05-17 Thread Wolfgang Denk
Dear Aneesh V, In message <4dd21843.4060...@ti.com> you wrote: > > > you could use > > > > #define OMAP4430_ES1_0 10 > > #define OMAP4430_ES2_0 20 > > #define OMAP4430_ES2_1 21 > > #define OMAP4430_ES2_2 22 > > > > And then use a plain > > > > sprintf(omap4_rev, "OMAP4430 ES%d

Re: [U-Boot] [PATCH v2 02/22] omap4: add OMAP4430 revision check

2011-05-16 Thread Aneesh V
Hi Wolfgang, On Monday 16 May 2011 09:05 PM, Wolfgang Denk wrote: > Dear Aneesh V, > ... >> >> 1. Please note that the above function is just for getting the string >> not for the revision itself. To get the revision we have >> omap4_revision(). > > Well, when you already have such a funxction, th

Re: [U-Boot] [PATCH v2 02/22] omap4: add OMAP4430 revision check

2011-05-16 Thread Wolfgang Denk
Dear Aneesh V, In message <4dd11511.1060...@ti.com> you wrote: > > >> + const char *omap4_rev = NULL; > >> + switch (omap4_revision()) { > >> + case OMAP4430_ES1_0: > >> + omap4_rev = "OMAP4430 ES1.0"; > >> + break; > >> + case OMAP4430_ES2_0: > >> + omap4_rev = "OMA

Re: [U-Boot] [PATCH v2 02/22] omap4: add OMAP4430 revision check

2011-05-16 Thread Aneesh V
Hi Wolfgang, On Monday 16 May 2011 12:39 AM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<1305472900-4004-3-git-send-email-ane...@ti.com> you wrote: >> Signed-off-by: Aneesh V >> --- >> V2: >> * Added a revision string in addition to the revision number >>Helps in printing out the OMA

Re: [U-Boot] [PATCH v2 02/22] omap4: add OMAP4430 revision check

2011-05-15 Thread Wolfgang Denk
Dear Aneesh V, In message <1305472900-4004-3-git-send-email-ane...@ti.com> you wrote: > Signed-off-by: Aneesh V > --- > V2: > * Added a revision string in addition to the revision number > Helps in printing out the OMAP revision at bootup ... > +const char *omap4_rev_string(void) > +{ > + c

[U-Boot] [PATCH v2 02/22] omap4: add OMAP4430 revision check

2011-05-15 Thread Aneesh V
Signed-off-by: Aneesh V --- V2: * Added a revision string in addition to the revision number Helps in printing out the OMAP revision at bootup --- arch/arm/cpu/armv7/omap4/board.c| 58 +++ arch/arm/include/asm/arch-omap4/omap4.h | 17 ++--- arch/arm/i