[U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code

2013-05-06 Thread dirk . eibach
From: Dirk Eibach Signed-off-by: Dirk Eibach --- Changes in v2: None board/gdsys/405ep/405ep.c | 12 +++ board/gdsys/common/osd.c | 70 +--- 2 files changed, 38 insertions(+), 44 deletions(-) diff --git a/board/gdsys/405ep/405ep.c b/board/gdsys

Re: [U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code

2013-05-06 Thread Wolfgang Denk
Dear dirk.eib...@gdsys.cc, In message <1367847325-21463-5-git-send-email-dirk.eib...@gdsys.cc> you wrote: > ... > + fpga_set_reg(k, REG(reflection_low), > + REFLECTION_TESTPATTERN); This breaks bisecting. You reference functions which you only

Re: [U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code

2013-05-06 Thread Tom Rini
On Mon, May 06, 2013 at 04:07:15PM +0200, Wolfgang Denk wrote: > Dear dirk.eib...@gdsys.cc, > > In message <1367847325-21463-5-git-send-email-dirk.eib...@gdsys.cc> you wrote: > > > ... > > + fpga_set_reg(k, REG(reflection_low), > > +REFLECTION_TEST

Re: [U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code

2013-05-06 Thread Dirk Eibach
Hi Tom, On Mon, May 06, 2013 at 04:07:15PM +0200, Wolfgang Denk wrote: Dear dirk.eib...@gdsys.cc, In message <1367847325-21463-5-git-send-email-dirk.eib...@gdsys.cc> you wrote: ... + fpga_set_reg(k, REG(reflection_low), +REFLECTION

Re: [U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code

2013-05-06 Thread Tom Rini
On Mon, May 06, 2013 at 05:02:12PM +0200, Dirk Eibach wrote: > Hi Tom, > > >On Mon, May 06, 2013 at 04:07:15PM +0200, Wolfgang Denk wrote: > >>Dear dirk.eib...@gdsys.cc, > >> > >>In message > >><1367847325-21463-5-git-send-email-dirk.eib...@gdsys.cc> you > >>wrote: > >>> > >>... > >>>+

Re: [U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code

2013-05-06 Thread Dirk Eibach
Hi Tom, On Mon, May 06, 2013 at 05:02:12PM +0200, Dirk Eibach wrote: Hi Tom, On Mon, May 06, 2013 at 04:07:15PM +0200, Wolfgang Denk wrote: Dear dirk.eib...@gdsys.cc, In message <1367847325-21463-5-git-send-email-dirk.eib...@gdsys.cc> you wrote: ... + fpga_set_reg(