Re: [U-Boot] [PATCH v2 04/12] i2c: add Faraday FTI2C010 I2C controller support

2013/4/18 Wolfgang Denk : > Dear Kuo-Jung Su, > > In message <1366277139-29728-5-git-send-email-dant...@gmail.com> you wrote: > ... >> +#define I2C_READ(r) le32_to_cpu(readl(r)) >> +#define I2C_WRITE(v, r) writel(cpu_to_le32(v), r) > > Please drop these macros and use the real functio

Re: [U-Boot] [PATCH v2 04/12] i2c: add Faraday FTI2C010 I2C controller support

Dear Kuo-Jung Su, In message <1366277139-29728-5-git-send-email-dant...@gmail.com> you wrote: ... > +#define I2C_READ(r) le32_to_cpu(readl(r)) > +#define I2C_WRITE(v, r) writel(cpu_to_le32(v), r) Please drop these macros and use the real functions instead. Best regards, Wolfgang

[U-Boot] [PATCH v2 04/12] i2c: add Faraday FTI2C010 I2C controller support

From: Kuo-Jung Su Faraday FTI2C010 is a multi-function I2C controller which supports both master and slave mode. This patch simplily implements the master mode only. Signed-off-by: Kuo-Jung Su CC: Heiko Schocher --- drivers/i2c/Makefile |1 + drivers/i2c/fti2c010.c | 363 ++