Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-20 Thread Andy Shevchenko
On Wed, Nov 21, 2018 at 12:04 AM Alexander Graf wrote: > On 20.11.18 19:32, Andy Shevchenko wrote: > > On Thu, Nov 15, 2018 at 11:45:32AM -0800, Simon Glass wrote: > >> On 15 November 2018 at 09:58, Andy Shevchenko > >> wrote: > >>> + u64 addr; > >> > >> ulong > > > > This, unfortunate

Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-20 Thread Alexander Graf
On 20.11.18 19:32, Andy Shevchenko wrote: > On Thu, Nov 15, 2018 at 11:45:32AM -0800, Simon Glass wrote: >> On 15 November 2018 at 09:58, Andy Shevchenko >> wrote: > >>> +/* REVISIT: ACPI GAS specification implied */ >>> +struct serial_device_info { >>> + unsigned int baudrate; >>> +

Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-20 Thread Andy Shevchenko
On Thu, Nov 15, 2018 at 11:45:32AM -0800, Simon Glass wrote: > On 15 November 2018 at 09:58, Andy Shevchenko > wrote: > > +/* REVISIT: ACPI GAS specification implied */ > > +struct serial_device_info { > > + unsigned int baudrate; > > + u8 addr_space; /* 0 - MMIO, 1 - IO */ >

Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-20 Thread Andy Shevchenko
On Thu, Nov 15, 2018 at 09:09:55PM +0100, Alexander Graf wrote: > > > On 15.11.18 20:31, Andy Shevchenko wrote: > > On Thu, Nov 15, 2018 at 8:22 PM Alexander Graf wrote: > >> On 15.11.18 18:58, Andy Shevchenko wrote: > >>> New callback will give a necessary information to fill up ACPI SPCR table

Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-20 Thread Andy Shevchenko
On Thu, Nov 15, 2018 at 12:22:31PM -0800, Simon Glass wrote: > On 15 November 2018 at 11:51, Andy Shevchenko > wrote: > > On Thu, Nov 15, 2018 at 9:46 PM Simon Glass wrote: > >> On 15 November 2018 at 09:58, Andy Shevchenko > >> wrote: > >> > +int serial_getinfo(struct serial_device_info *info

Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-15 Thread Simon Glass
Hi Andy, On 15 November 2018 at 11:51, Andy Shevchenko wrote: > On Thu, Nov 15, 2018 at 9:46 PM Simon Glass wrote: >> On 15 November 2018 at 09:58, Andy Shevchenko >> wrote: >> > >> > New callback will give a necessary information to fill up ACPI SPCR table, >> > for example. Maybe used later f

Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-15 Thread Alexander Graf
On 15.11.18 20:31, Andy Shevchenko wrote: > On Thu, Nov 15, 2018 at 8:22 PM Alexander Graf wrote: >> On 15.11.18 18:58, Andy Shevchenko wrote: >>> New callback will give a necessary information to fill up ACPI SPCR table, >>> for example. Maybe used later for other purposes. > >>> +/* REVISIT:

Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-15 Thread Andy Shevchenko
On Thu, Nov 15, 2018 at 9:46 PM Simon Glass wrote: > On 15 November 2018 at 09:58, Andy Shevchenko > wrote: > > > > New callback will give a necessary information to fill up ACPI SPCR table, > > for example. Maybe used later for other purposes. > Seems useful to me. Thanks. What do you think ab

Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-15 Thread Simon Glass
Hi Andy, On 15 November 2018 at 09:58, Andy Shevchenko wrote: > > New callback will give a necessary information to fill up ACPI SPCR table, > for example. Maybe used later for other purposes. > > Signed-off-by: Andy Shevchenko > --- > drivers/serial/serial-uclass.c | 21 + >

Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-15 Thread Andy Shevchenko
On Thu, Nov 15, 2018 at 8:22 PM Alexander Graf wrote: > On 15.11.18 18:58, Andy Shevchenko wrote: > > New callback will give a necessary information to fill up ACPI SPCR table, > > for example. Maybe used later for other purposes. > > +/* REVISIT: ACPI GAS specification implied */ > > What does t

Re: [U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-15 Thread Alexander Graf
On 15.11.18 18:58, Andy Shevchenko wrote: > New callback will give a necessary information to fill up ACPI SPCR table, > for example. Maybe used later for other purposes. > > Signed-off-by: Andy Shevchenko > --- > drivers/serial/serial-uclass.c | 21 + > include/common.h

[U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

2018-11-15 Thread Andy Shevchenko
New callback will give a necessary information to fill up ACPI SPCR table, for example. Maybe used later for other purposes. Signed-off-by: Andy Shevchenko --- drivers/serial/serial-uclass.c | 21 + include/common.h | 3 +++ include/serial.h | 17