Re: [U-Boot] [PATCH v2 11/16] Define board_quiesce_devices() in a shared location

2017-12-04 Thread Heinrich Schuchardt
On 12/04/2017 11:41 PM, Heinrich Schuchardt wrote: On 12/04/2017 10:28 PM, Simon Glass wrote: This undocumented function relies on arch-specific code to declare a nop Undocumented code is unsatisfactory. Please, add a comment to the function. Sorry I missed you put that in a separate

Re: [U-Boot] [PATCH v2 11/16] Define board_quiesce_devices() in a shared location

2017-12-04 Thread Heinrich Schuchardt
On 12/04/2017 10:28 PM, Simon Glass wrote: This undocumented function relies on arch-specific code to declare a nop Undocumented code is unsatisfactory. Please, add a comment to the function. Best regards Heinrich weak version. Add the weak function in common code instead to avoid having

[U-Boot] [PATCH v2 11/16] Define board_quiesce_devices() in a shared location

2017-12-04 Thread Simon Glass
This undocumented function relies on arch-specific code to declare a nop weak version. Add the weak function in common code instead to avoid having to duplicate the same function in each arch. Signed-off-by: Simon Glass --- Changes in v2: None