Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-28 Thread Simon Glass
Hi Stefan, On Thu, Jun 27, 2013 at 9:12 PM, Stefan Roese s...@denx.de wrote: Hi Simon, On 06/28/2013 04:14 AM, Simon Glass wrote: I can create something with or without compression and I cannot see the failure. Tom is seeing it though. I will see if I can get another board to try. If

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-28 Thread Stefan Roese
On 06/28/2013 08:58 AM, Simon Glass wrote: One idea: It might have something to do with the interrupt disabling, as powerpc compresses to 0. And thats the location of the interrupt vectors (timer?). Just an idea. Do you remember shuffling the disable_interrupts() call around?

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-28 Thread Simon Glass
Hi Stefan, On Fri, Jun 28, 2013 at 12:04 AM, Stefan Roese s...@denx.de wrote: On 06/28/2013 08:58 AM, Simon Glass wrote: One idea: It might have something to do with the interrupt disabling, as powerpc compresses to 0. And thats the location of the interrupt vectors

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-28 Thread Simon Glass
Hi Stefan, On Fri, Jun 28, 2013 at 12:12 AM, Simon Glass s...@chromium.org wrote: Hi Stefan, On Fri, Jun 28, 2013 at 12:04 AM, Stefan Roese s...@denx.de wrote: On 06/28/2013 08:58 AM, Simon Glass wrote: One idea: It might have something to do with the interrupt disabling, as

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-27 Thread Stefan Roese
Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means that changes must be made to several places. Introduce do_bootm_states() which

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-27 Thread Tom Rini
On Thu, Jun 27, 2013 at 03:40:36PM +0200, Stefan Roese wrote: Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means that changes must

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-27 Thread Simon Glass
Hi Stefann, On Thu, Jun 27, 2013 at 6:40 AM, Stefan Roese s...@denx.de wrote: Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-27 Thread Simon Glass
Hi Stefan, On Thu, Jun 27, 2013 at 6:40 AM, Stefan Roese s...@denx.de wrote: Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-27 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/27/2013 03:51 PM, Simon Glass wrote: Hi Stefan, On Thu, Jun 27, 2013 at 6:40 AM, Stefan Roese s...@denx.de mailto:s...@denx.de wrote: Hi Simon, On 06/11/2013 08:14 PM, Simon Glass wrote: At present the bootm code is mostly

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-27 Thread Simon Glass
Hi Stefan, I can create something with or without compression and I cannot see the failure. Tom is seeing it though. I will see if I can get another board to try. If you have any ideas please let me know. scanning bus 0 for devices... 2 USB Device(s) found scanning usb for storage

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-27 Thread Stefan Roese
Hi Simon, On 06/28/2013 04:14 AM, Simon Glass wrote: I can create something with or without compression and I cannot see the failure. Tom is seeing it though. I will see if I can get another board to try. If you have any ideas please let me know. Sorry, but I don't have any ideas. I also

Re: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-27 Thread Simon Glass
Hi Stefan, On Thu, Jun 27, 2013 at 9:12 PM, Stefan Roese s...@denx.de wrote: Hi Simon, On 06/28/2013 04:14 AM, Simon Glass wrote: I can create something with or without compression and I cannot see the failure. Tom is seeing it though. I will see if I can get another board to try. If

[U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

2013-06-11 Thread Simon Glass
At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means that changes must be made to several places. Introduce do_bootm_states() which performs selected portions of the bootm work, so that both